fix(ui): gate detail modals on user intent, not on the row resolving

The sweep's modal re-key (holding the row's id and re-resolving it, rather than holding the record) also used that resolve as the modal's visibility gate. That makes the modal's existence a function of list contents: any render where the row is momentarily unresolvable unmounts the whole subtree and disposes every event-handler id inside it, Close's included. A click already in flight against a disposed handler makes the renderer throw GetRequiredEventBindingEntry during DispatchEventAsync — which is how this surfaced, as an intermittent failure of CloseButton_DismissesModal (989/990 on one run, green on re-run). The record-held form made that structurally impossible: the modal existed because the user opened it, and no list mutation could retract that. This restores the property while keeping the re-key's actual benefit. Visibility now gates on the held id; the resolve drives only content. An unresolvable row degrades to an explicit notice and hides the row-scoped actions, while the frame and Close stay mounted. Detail fetched by id still renders, so the user does not lose the body they opened. Applied to all four surfaces that shared the construction: NotificationReport, ConfigurationAuditLog, ParkedMessages (offcanvas drawer) and SiteCallsReport. Modal_StaysOpen_WhenItsRowLeavesThePage drops the opened row from the next query and asserts the modal survives, keeps its fetched body, hides Retry/Discard, and that Close still works. It was run against a deliberately restored defective gate and failed there before passing here — a regression test that passes both ways would be worthless against a race. 20 consecutive runs of the previously flaky class: no failures. CentralUI.Tests 991/991, solution build 0/0. The plan doc gains a section recording that the sweep was reported as behaviour-preserving when it was not, and why the merge review missed it.
2026-08-11 06:03:06 -04:00
parent 9e243493fb
commit d14e0ee4b1
6 changed files with 238 additions and 45 deletions
@@ -180,24 +180,40 @@
    }

    @* The state modal holds only the entry's id and re-resolves the row from the
-       page currently on screen on every render (ModalEntry()). A refetch that
-       replaces the entry list therefore never leaves this surface rendering a
-       stale record, and an entry that has left the page closes the modal instead
-       of stranding it. *@
-    @if (ModalEntry() is { } modalEntry)
+       page currently on screen on every render (ModalEntry()), so it never
+       renders a stale record after a refetch replaces the entry list.
+
+       Visibility is gated on _modalEntryId — user intent — NOT on the resolve
+       succeeding. Gating the subtree on ModalEntry() would make the modal's
+       existence a function of list contents, so a render where the entry is
+       momentarily absent unmounts the subtree and disposes the event-handler ids
+       inside it, Close included; a click already in flight against a disposed
+       handler throws GetRequiredEventBindingEntry. Only the user closes this. *@
+    @if (_modalEntryId is { } modalEntryId)
    {
+        var modalEntry = ModalEntry();
        <div class="modal-backdrop fade show"></div>
        <div class="modal fade show d-block" tabindex="-1" role="dialog">
            <div class="modal-dialog modal-lg modal-dialog-centered modal-dialog-scrollable" role="document">
                <div class="modal-content">
                    <div class="modal-header">
                        <h5 class="modal-title">
-                            Audit entry @modalEntry.Id — @modalEntry.EntityType state
+                            Audit entry @modalEntryId@(modalEntry is null ? "" : $" — {modalEntry.EntityType} state")
                        </h5>
                        <button type="button" class="btn-close" @onclick="CloseStateModal" aria-label="Close"></button>
                    </div>
                    <div class="modal-body">
-                        <pre class="bg-body-secondary p-2 rounded small mb-0">@FormatJson(modalEntry.AfterStateJson!)</pre>
+                        @if (modalEntry is null)
+                        {
+                            <div class="alert alert-secondary py-2 mb-0" data-test="modal-entry-gone">
+                                This entry is no longer in the current page of results,
+                                so its state can't be shown.
+                            </div>
+                        }
+                        else
+                        {
+                            <pre class="bg-body-secondary p-2 rounded small mb-0">@FormatJson(modalEntry.AfterStateJson!)</pre>
+                        }
                    </div>
                    <div class="modal-footer">
                        <button type="button" class="btn btn-outline-secondary btn-sm" @onclick="CloseStateModal">Close</button>