fix(communication)+fix(siteruntime): carry DetachedScriptThreads/ScriptRunShedCount/SiteStreamAlarmDropCount across the health wire; restore drained counters on failed send (arch-review 2026-08-19 P8-1)

2026-08-19 14:47:04 -04:00
parent eca0ab768d
commit d0a748e632
9 changed files with 228 additions and 45 deletions
@@ -286,12 +286,19 @@ public interface ISiteHealthCollector
    /// <param name="deadLetters">Dead letter count to add back.</param>
    /// <param name="siteAuditWriteFailures">Site audit write failure count to add back.</param>
    /// <param name="auditRedactionFailures">Audit redaction failure count to add back.</param>
+    /// <param name="scriptRunShedCount">
+    /// Interval-drained script/alarm run-shed count to add back (arch-review 2026-08-19
+    /// P8-1). Additive trailing parameter defaulting to 0 so existing callers keep
+    /// compiling; <c>DetachedScriptThreads</c>/<c>SiteStreamAlarmDropCount</c> are
+    /// point-in-time gauges, not drained on collect, so they need no restore path.
+    /// </param>
    void AddIntervalCounters(
        int scriptErrors,
        int alarmErrors,
        int deadLetters,
        int siteAuditWriteFailures,
-        int auditRedactionFailures)
+        int auditRedactionFailures,
+        int scriptRunShedCount = 0)
    {
        // Default no-op so test fakes do not need to be updated. The real
        // SiteHealthCollector overrides this with the Interlocked.Add restore.