fix(kpi): promote catalog metric literals to shared KpiMetrics constants — drift becomes a compile error (plan R2-04 T8)

2026-07-13 10:15:40 -04:00
parent 1c8b2bc745
commit cd93ad3976
5 changed files with 53 additions and 21 deletions
@@ -148,4 +148,22 @@ public class KpiMetricAggregationTests
            KpiRollupAggregation.Rate,
            KpiMetricAggregationCatalog.Resolve(KpiSources.SiteCallAudit, "deliveredLastInterval"));
    }
+
+    // ---- Task 8: catalog metric literals promoted to shared KpiMetrics constants (R4) ----
+
+    [Fact]
+    public void PromotedMetricConstants_LockHistoricalPersistedValues()
+    {
+        // Persisted data contract — these are symbol promotions, NOT renames.
+        Assert.Equal("deliveredLastInterval", KpiMetrics.SiteCallAudit.DeliveredLastInterval);
+        Assert.Equal("alarmEvalErrors", KpiMetrics.SiteHealth.AlarmEvalErrors);
+        Assert.Equal("eventLogWriteFailures", KpiMetrics.SiteHealth.EventLogWriteFailures);
+    }
+
+    [Theory]
+    [InlineData(KpiSources.SiteCallAudit, KpiMetrics.SiteCallAudit.DeliveredLastInterval)]
+    [InlineData(KpiSources.SiteHealth, KpiMetrics.SiteHealth.AlarmEvalErrors)]
+    [InlineData(KpiSources.SiteHealth, KpiMetrics.SiteHealth.EventLogWriteFailures)]
+    public void Resolve_PromotedRatePairs_StillClassifyAsRate(string source, string metric)
+        => Assert.Equal(KpiRollupAggregation.Rate, KpiMetricAggregationCatalog.Resolve(source, metric));
 }