merge(r2): r2-plan08

# Conflicts: # src/ZB.MOM.WW.ScadaBridge.Communication/CommunicationOptionsValidator.cs
2026-07-13 11:10:15 -04:00
parent ca4b0dd849 4f39cfd6c6
commit ccee558ca7
42 changed files with 1094 additions and 79 deletions
@@ -0,0 +1,30 @@
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
+
+namespace ZB.MOM.WW.ScadaBridge.DataConnectionLayer.Tests;
+
+/// <summary>
+/// Locks the config section <see cref="ServiceCollectionExtensions.AddDataConnectionLayer"/>
+/// binds (arch-review 08 round 2 NF8). Every real appsettings nests this section under
+/// <c>ScadaBridge:</c>; binding a root-level <c>DataConnectionLayer</c> section reads config
+/// that no deployment writes — the drift the Host duplicate was silently masking.
+/// AddDataConnectionLayer alone must bind the canonical <c>ScadaBridge:DataConnection</c> section.
+/// </summary>
+public class DataConnectionOptionsBindingTests
+{
+    [Fact]
+    public void AddDataConnectionLayer_BindsTheScadaBridgeDataConnectionSection()
+    {
+        var config = new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string, string?>
+        {
+            ["ScadaBridge:DataConnection:ReconnectInterval"] = "00:00:42",
+        }).Build();
+        var services = new ServiceCollection();
+        services.AddSingleton<IConfiguration>(config);
+        services.AddDataConnectionLayer();
+        using var sp = services.BuildServiceProvider();
+        Assert.Equal(TimeSpan.FromSeconds(42),
+            sp.GetRequiredService<IOptions<DataConnectionOptions>>().Value.ReconnectInterval);
+    }
+}