fix(esg): park buffered calls that fail deterministically with ArgumentException (path template/verb) instead of retrying to exhaustion (plan R2-06 T3)

2026-07-13 09:51:30 -04:00
parent 9668600c38
commit cc94b3a68c
2 changed files with 56 additions and 1 deletions
@@ -1341,4 +1341,40 @@ public class ExternalSystemClientTests
            () => client.CallAsync("TestAPI", "getRecipe"));
        Assert.Contains("id", ex.Message);
    }
+
+    [Fact]
+    public async Task DeliverBuffered_PathTemplateNowUnresolvable_ReturnsFalseSoMessageParks()
+    {
+        // Arch-review R2 N2: a method whose path gained a {param} placeholder AFTER
+        // calls were buffered throws ArgumentException deterministically for every
+        // already-buffered message — it must park immediately (permanent), not burn
+        // MaxRetries "transient" attempts (the S&F sweep's catch-all retries any throw).
+        var system = new ExternalSystemDefinition("TestAPI", "https://api.example.com", "none") { Id = 1 };
+        var method = new ExternalSystemMethod("getRecipe", "GET", "/recipes/{id}") { Id = 1, ExternalSystemDefinitionId = 1 };
+        StubResolution(system, method);
+        _httpClientFactory.CreateClient(Arg.Any<string>())
+            .Returns(new HttpClient(new MockHttpMessageHandler(HttpStatusCode.OK, "{}")));
+        var client = new ExternalSystemClient(
+            _httpClientFactory, _repository, NullLogger<ExternalSystemClient>.Instance);
+
+        // BufferedCall carries Parameters:null — the {id} placeholder has no value.
+        var delivered = await client.DeliverBufferedAsync(BufferedCall("TestAPI", "getRecipe"));
+
+        Assert.False(delivered);
+    }
+
+    [Fact]
+    public async Task DeliverBuffered_UnsupportedVerbOnStoredMethod_ReturnsFalseSoMessageParks()
+    {
+        // ValidateHttpMethod throws the same deterministic ArgumentException shape.
+        var system = new ExternalSystemDefinition("TestAPI", "https://api.example.com", "none") { Id = 1 };
+        var method = new ExternalSystemMethod("oddVerb", "FOO", "/p") { Id = 1, ExternalSystemDefinitionId = 1 };
+        StubResolution(system, method);
+        var client = new ExternalSystemClient(
+            _httpClientFactory, _repository, NullLogger<ExternalSystemClient>.Instance);
+
+        var delivered = await client.DeliverBufferedAsync(BufferedCall("TestAPI", "oddVerb"));
+
+        Assert.False(delivered);
+    }
 }