From ca9ee5ea2ac72e3306f431fb1ad00c68fd6b70dc Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Tue, 16 Jun 2026 16:32:28 -0400 Subject: [PATCH] =?UTF-8?q?fix(ui):=20MV-14=20review=20=E2=80=94=20surface?= =?UTF-8?q?=20SetAttributeOverride=20failures=20in=20InstanceConfigure=20s?= =?UTF-8?q?ave=20loop=20(no=20false=20success=20toast)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Components/Pages/Deployment/InstanceConfigure.razor | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Deployment/InstanceConfigure.razor b/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Deployment/InstanceConfigure.razor index 4ce81ea9..582438d4 100644 --- a/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Deployment/InstanceConfigure.razor +++ b/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Deployment/InstanceConfigure.razor @@ -973,13 +973,20 @@ return; } + var failures = new List(); foreach (var (attrName, value) in toSave) { var result = await InstanceService.SetAttributeOverrideAsync(Id, attrName, value, user); if (result.IsSuccess) _existingOverrides[attrName] = result.Value!; + else + failures.Add($"{attrName}: {result.Error}"); } - _toast.ShowSuccess($"Saved {toSave.Count} override(s)."); + if (failures.Count > 0) + _toast.ShowError($"Failed to save {failures.Count} override(s): {string.Join("; ", failures)}"); + var savedCount = toSave.Count - failures.Count; + if (savedCount > 0) + _toast.ShowSuccess($"Saved {savedCount} override(s)."); } catch (Exception ex) {