feat(sitestream): validate live-alarm-cache options + active-aggregator/reconnect telemetry (plan #10 T6)

Extend CommunicationOptionsValidator with eager bounds for the four T4 live-alarm-cache options (linger >= 0, reconcile > 0, seed concurrency 1..64, subscribers-per-site >= 1). Enforce the per-site viewer cap fail-safe in SiteAlarmLiveCacheService.Subscribe (reject excess viewers with a no-op disposable rather than growing the list or throwing into the Blazor render path). Surface two telemetry instruments on the existing ScadaBridgeTelemetry meter: an active-aggregator observable gauge and a reconnect counter, wired from the aggregator actor's PreStart/PostStop and its NodeA<->NodeB flip / reconcile-driven reopen. Claude-Session: https://claude.ai/code/session_01MtdgwpEeCUn6cUA5f1LMPj
2026-07-10 12:33:40 -04:00
parent b91ed3c840
commit c4f97d0e87
8 changed files with 263 additions and 5 deletions
@@ -36,4 +36,54 @@ public class CommunicationOptionsValidatorTests
        Assert.True(result.Failed);
        Assert.Contains("GrpcMaxConcurrentStreams", result.FailureMessage);
    }
+
+    // ── Aggregated live alarm cache options (plan #10, Task 6) ───────────────────
+
+    [Fact]
+    public void ZeroLiveAlarmCacheLinger_IsValid()
+    {
+        // Zero linger = stop the aggregator immediately when the last viewer leaves.
+        var result = Validate(new CommunicationOptions { LiveAlarmCacheLinger = TimeSpan.Zero });
+        Assert.True(result.Succeeded, result.FailureMessage);
+    }
+
+    [Fact]
+    public void NegativeLiveAlarmCacheLinger_IsRejected()
+    {
+        var result = Validate(new CommunicationOptions { LiveAlarmCacheLinger = TimeSpan.FromSeconds(-1) });
+        Assert.True(result.Failed);
+        Assert.Contains("LiveAlarmCacheLinger", result.FailureMessage);
+    }
+
+    [Fact]
+    public void ZeroLiveAlarmCacheReconcileInterval_IsRejected()
+    {
+        var result = Validate(new CommunicationOptions { LiveAlarmCacheReconcileInterval = TimeSpan.Zero });
+        Assert.True(result.Failed);
+        Assert.Contains("LiveAlarmCacheReconcileInterval", result.FailureMessage);
+    }
+
+    [Fact]
+    public void ZeroLiveAlarmCacheSeedConcurrency_IsRejected()
+    {
+        var result = Validate(new CommunicationOptions { LiveAlarmCacheSeedConcurrency = 0 });
+        Assert.True(result.Failed);
+        Assert.Contains("LiveAlarmCacheSeedConcurrency", result.FailureMessage);
+    }
+
+    [Fact]
+    public void ExcessiveLiveAlarmCacheSeedConcurrency_IsRejected()
+    {
+        var result = Validate(new CommunicationOptions { LiveAlarmCacheSeedConcurrency = 65 });
+        Assert.True(result.Failed);
+        Assert.Contains("LiveAlarmCacheSeedConcurrency", result.FailureMessage);
+    }
+
+    [Fact]
+    public void ZeroLiveAlarmCacheMaxSubscribersPerSite_IsRejected()
+    {
+        var result = Validate(new CommunicationOptions { LiveAlarmCacheMaxSubscribersPerSite = 0 });
+        Assert.True(result.Failed);
+        Assert.Contains("LiveAlarmCacheMaxSubscribersPerSite", result.FailureMessage);
+    }
 }