feat(inbound-api): machine-readable error codes per spec (incl. SITE_UNREACHABLE) + 415 for non-JSON bodies

Claude-Session: https://claude.ai/code/session_01MtdgwpEeCUn6cUA5f1LMPj
2026-07-10 04:29:55 -04:00
parent 761729b5d0
commit b5e80d4c00
8 changed files with 248 additions and 30 deletions
@@ -97,6 +97,32 @@ public class InboundScriptExecutorTests
        Assert.Equal("Internal script error", result.ErrorMessage);
    }

+    [Fact]
+    public async Task RoutedSiteUnreachable_Returns500WithSiteUnreachableCode()
+    {
+        // C3: a routed call whose site is unreachable must surface the machine-readable
+        // SITE_UNREACHABLE code (spec Component-InboundAPI failure body) rather than
+        // collapsing into a generic SCRIPT_ERROR.
+        var locator = Substitute.For<IInstanceLocator>();
+        locator.GetSiteIdForInstanceAsync("X", Arg.Any<CancellationToken>()).Returns("SiteA");
+        var router = Substitute.For<IInstanceRouter>();
+        router.RouteToCallAsync("SiteA", Arg.Any<RouteToCallRequest>(), Arg.Any<CancellationToken>())
+            .Returns(ci => new RouteToCallResponse(
+                ((RouteToCallRequest)ci[1]).CorrelationId,
+                Success: false, ReturnValue: null, ErrorMessage: "Site unreachable",
+                DateTimeOffset.UtcNow));
+        var route = new RouteHelper(locator, router);
+
+        var method = new ApiMethod("routed", "return await Route.To(\"X\").Call(\"s\");")
+        { Id = 7, TimeoutSeconds = 10 };
+
+        var result = await _executor.ExecuteAsync(
+            method, new Dictionary<string, object?>(), route, TimeSpan.FromSeconds(10));
+
+        Assert.False(result.Success);
+        Assert.Equal("SITE_UNREACHABLE", result.ErrorCode);
+    }
+
    [Fact]
    public async Task HandlerTimesOut_ReturnsTimeoutError()
    {