feat(scripts): read-only, allow-listed Files global for site scripts; Delmia test receiver parses recipe files

Script file access (design docs/plans/2026-09-28-script-file-access-design.md): Files.ReadTextAsync / ReadLinesAsync / ExistsAsync on site ScriptGlobals (+ Instance.Files), backed by the site-singleton ScriptFileReader. The one host-mediated exception to the System.IO ban - scripts still never name a System.IO type. OFF by default: ScadaBridge:SiteRuntime:ScriptFileAccess:AllowedRoots (empty = every call throws Disabled) + MaxFileBytes (1 MiB, validated 1..64 MiB, roots must be absolute). Guard: fully qualified, no device paths / ADS, canonical path strictly inside a root (directory-boundary match), no reparse point on the file or any directory below the root, size cap before and during the read. Errors are one Commons type, ScriptFileAccessException(+ScriptFileAccessFailure); Commons.Types.Scripts joins the default script imports on every surface so it binds by short name. Mirrored on ScriptCompileSurface (CompileFiles, parity-pinned) and the Test Run sandbox (binds, refuses Disabled). Inbound (central) scripts do not get it. Rig: docker/recipes (sample RecipeValueName,RecipeValue files incl. an invalid one) bind-mounted read-only at /app/recipes on both site-a nodes with AllowedRoots [/app/recipes]. The TestMesMachine SimDelmiaRecipe simulator now reads + parses the downloaded file, converts each value to its recipe tag's type and loads it all-or-nothing (14 new TestDelmiaReceiver attributes); verify-mes-test-machine.sh group A covers accept / re-download / invalid lines / NotFound / OutsideAllowedRoots, VERIFY_GROUPS selects groups (rig: AD).
2026-09-28 10:36:42 -04:00
parent 0af0672597
commit b3021e7c5f
31 changed files with 1157 additions and 77 deletions
@@ -58,12 +58,37 @@ public class RoslynScriptCompilerTests
            var viaInstance = await Instance.Alarms.CurrentAsync();
            var mesReportable = await Alarms.MesReportableAsync();
            var flaggedAlarms = mesReportable.Where(a => a.IsMesReportable).ToList();
+            var recipeText = await Files.ReadTextAsync(@"C:\recipes\r.txt");
+            var recipeLines = await Instance.Files.ReadLinesAsync(@"C:\recipes\r.txt");
+            var recipeThere = await Files.ExistsAsync(@"C:\recipes\r.txt");
            """;

        var diagnostics = RoslynScriptCompiler.Compile(code, typeof(ScriptCompileSurface));
        Assert.Empty(diagnostics);
    }

+    [Fact]
+    public void Compile_Empty_ForARecipeFileParsingScript()
+    {
+        // Script file access (design 2026-09-28): the Files global + catching the Commons
+        // ScriptFileAccessException by name must bind at design time — scripts cannot name the
+        // System.IO exception types.
+        const string code = """
+            var path = (string)Parameters["DownloadPath"];
+            try {
+                foreach (var line in await Files.ReadLinesAsync(path, CancellationToken)) {
+                    var parts = line.Split(',', 2);
+                    if (parts.Length == 2 && double.TryParse(parts[1], out var d)) { }
+                }
+                return true;
+            } catch (ScriptFileAccessException ex) when (ex.Failure == ScriptFileAccessFailure.NotFound) {
+                return false;
+            }
+            """;
+
+        Assert.Empty(RoslynScriptCompiler.Compile(code, typeof(ScriptCompileSurface)));
+    }
+
    [Fact]
    public void Compile_Empty_ForTheMesAlarmStatusScriptShape()
    {