feat(options): eager startup validation for Communication + DataConnectionLayer options (arch-review 08 §1.5)

Claude-Session: https://claude.ai/code/session_01MtdgwpEeCUn6cUA5f1LMPj
2026-07-10 06:48:06 -04:00
parent 187fbd7cc8
commit af2cfde484
8 changed files with 203 additions and 2 deletions
@@ -0,0 +1,39 @@
+using Microsoft.Extensions.Options;
+
+namespace ZB.MOM.WW.ScadaBridge.Communication.Tests;
+
+/// <summary>
+/// Regression: <see cref="CommunicationOptions"/> timeouts feed per-pattern Ask
+/// deadlines and gRPC keepalive/stream-lifetime settings; a zero/negative value
+/// (or a non-positive <c>GrpcMaxConcurrentStreams</c>) must be rejected at startup
+/// by an <see cref="IValidateOptions{TOptions}"/> with a clear, key-naming message
+/// rather than surfacing at first Ask/gRPC use.
+/// </summary>
+public class CommunicationOptionsValidatorTests
+{
+    private static ValidateOptionsResult Validate(CommunicationOptions options) =>
+        new CommunicationOptionsValidator().Validate(Options.DefaultName, options);
+
+    [Fact]
+    public void DefaultOptions_AreValid()
+    {
+        var result = Validate(new CommunicationOptions());
+        Assert.True(result.Succeeded, result.FailureMessage);
+    }
+
+    [Fact]
+    public void ZeroDeploymentTimeout_IsRejected()
+    {
+        var result = Validate(new CommunicationOptions { DeploymentTimeout = TimeSpan.Zero });
+        Assert.True(result.Failed);
+        Assert.Contains("DeploymentTimeout", result.FailureMessage);
+    }
+
+    [Fact]
+    public void NonPositiveGrpcMaxConcurrentStreams_IsRejected()
+    {
+        var result = Validate(new CommunicationOptions { GrpcMaxConcurrentStreams = 0 });
+        Assert.True(result.Failed);
+        Assert.Contains("GrpcMaxConcurrentStreams", result.FailureMessage);
+    }
+}