feat(options): eager startup validation for Communication + DataConnectionLayer options (arch-review 08 §1.5)

Claude-Session: https://claude.ai/code/session_01MtdgwpEeCUn6cUA5f1LMPj
2026-07-10 06:48:06 -04:00
parent 187fbd7cc8
commit af2cfde484
8 changed files with 203 additions and 2 deletions
@@ -0,0 +1,39 @@
+using ZB.MOM.WW.Configuration;
+
+namespace ZB.MOM.WW.ScadaBridge.DataConnectionLayer;
+
+/// <summary>
+/// Validates <see cref="DataConnectionOptions"/> at startup (ValidateOnStart) so a
+/// malformed "DataConnectionLayer" appsettings section fails fast at boot with a
+/// key-naming message instead of surfacing later at runtime. The intervals drive
+/// the reconnect/tag-resolution timers and the seed-read retry loop; a
+/// zero/negative duration (or a non-positive <c>SeedReadMaxAttempts</c>) would
+/// otherwise produce an opaque failure far from the offending config key.
+/// </summary>
+public sealed class DataConnectionOptionsValidator : OptionsValidatorBase<DataConnectionOptions>
+{
+    /// <inheritdoc />
+    protected override void Validate(ValidationBuilder builder, DataConnectionOptions options)
+    {
+        builder.RequireThat(options.ReconnectInterval > TimeSpan.Zero,
+            $"DataConnectionLayer:ReconnectInterval must be a positive duration (was {options.ReconnectInterval}).");
+
+        builder.RequireThat(options.TagResolutionRetryInterval > TimeSpan.Zero,
+            $"DataConnectionLayer:TagResolutionRetryInterval must be a positive duration (was {options.TagResolutionRetryInterval}).");
+
+        builder.RequireThat(options.WriteTimeout > TimeSpan.Zero,
+            $"DataConnectionLayer:WriteTimeout must be a positive duration (was {options.WriteTimeout}).");
+
+        builder.RequireThat(options.SeedReadTimeout > TimeSpan.Zero,
+            $"DataConnectionLayer:SeedReadTimeout must be a positive duration (was {options.SeedReadTimeout}).");
+
+        builder.RequireThat(options.StableConnectionThreshold > TimeSpan.Zero,
+            $"DataConnectionLayer:StableConnectionThreshold must be a positive duration (was {options.StableConnectionThreshold}).");
+
+        builder.RequireThat(options.SeedReadRetryDelay > TimeSpan.Zero,
+            $"DataConnectionLayer:SeedReadRetryDelay must be a positive duration (was {options.SeedReadRetryDelay}).");
+
+        builder.RequireThat(options.SeedReadMaxAttempts > 0,
+            $"DataConnectionLayer:SeedReadMaxAttempts must be positive (was {options.SeedReadMaxAttempts}).");
+    }
+}