fix(template-engine): resolve TemplateEngine-011,013,014 — remove dead converter, duplicate-id-safe cycle detection, unified deletion logic; TemplateEngine-012 deferred

2026-05-16 22:32:30 -04:00
parent 9e2416b34c
commit adb5e75ec3
9 changed files with 274 additions and 98 deletions
@@ -27,7 +27,10 @@ public static class CollisionDetector
        Template template,
        IReadOnlyList<Template> allTemplates)
    {
-        var lookup = allTemplates.ToDictionary(t => t.Id);
+        // Duplicate-tolerant lookup (see CycleDetector.BuildLookup): a plain
+        // ToDictionary(t => t.Id) throws if two templates share an Id (e.g.
+        // not-yet-saved templates carrying Id 0).
+        var lookup = CycleDetector.BuildLookup(allTemplates);
        var allMembers = new List<ResolvedMember>();

        // Collect direct (top-level) members