dohertj2/ScadaBridge
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

docs(code-review): resolve the 8 re-review findings (fixed in 9ab1c002)

Browse Source 
Flip DataConnectionLayer-029, InboundAPI-031, SiteRuntime-032/033,
StoreAndForward-028, AuditLog-017, CentralUI-037, ScriptAnalysis-009 from Open to
Resolved with the fixing commit + a one-line resolution each; regen README
(0 pending / 576 total across 25 modules).
This commit is contained in:
Joseph Doherty
2026-06-24 09:40:47 -04:00
parent 9ab1c00265
commit ad4744a295
8 changed files with 37 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code-reviews/StoreAndForward/findings.md
+3 -3
View File
@@ -8,7 +8,7 @@
| Last reviewed | 2026-06-24 |
| Reviewer | claude-agent |
| Commit reviewed | `1f9de8a2` |
| Open findings | 1 (025 Resolved; 026, 027 Deferred; 5 Deferred total: 002, 011, 012, 026, 027; all prior Open findings resolved) |
| Open findings | 0 (025 Resolved; 026, 027 Deferred; 5 Deferred total: 002, 011, 012, 026, 027; all prior Open findings resolved) |
## Summary
@@ -1765,7 +1765,7 @@ Focused re-review of the changes since the prior review — verifying the code-r
|--|--|
| Severity | Medium |
| Category | Correctness & logic bugs |
| Status | Open |
| Status | Resolved |
| Location | `src/ZB.MOM.WW.ScadaBridge.StoreAndForward/StoreAndForwardService.cs:459` |
**Description**
@@ -1778,4 +1778,4 @@ Reset the cached counter on stop alongside the guard, e.g. `Interlocked.Exchange
**Resolution**
_Unresolved._
Resolved in commit `9ab1c002` (2026-06-24): `StopAsync` now resets `_bufferedCount` to 0 alongside the registration guard, so a same-instance Stop->Start re-seeds the depth gauge from the durable Pending count on a clean base instead of doubling to ~2N. Regression test `StartAsync_AfterStop_ReseedsFromCleanBase_NoDoubleCount` added.