dohertj2/ScadaBridge
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

docs(code-review): resolve the 8 re-review findings (fixed in 9ab1c002)

Browse Source 
Flip DataConnectionLayer-029, InboundAPI-031, SiteRuntime-032/033,
StoreAndForward-028, AuditLog-017, CentralUI-037, ScriptAnalysis-009 from Open to
Resolved with the fixing commit + a one-line resolution each; regen README
(0 pending / 576 total across 25 modules).
This commit is contained in:
Joseph Doherty
2026-06-24 09:40:47 -04:00
parent 9ab1c00265
commit ad4744a295
8 changed files with 37 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code-reviews/SiteRuntime/findings.md
+5 -5
View File
@@ -8,7 +8,7 @@
| Last reviewed | 2026-06-24 |
| Reviewer | claude-agent |
| Commit reviewed | `1f9de8a2` |
| Open findings | 2 |
| Open findings | 0 |
## Summary
@@ -1668,7 +1668,7 @@ Focused re-review of the changes since the prior review — verifying the code-r
|--|--|
| Severity | Medium |
| Category | Correctness & logic bugs |
| Status | Open |
| Status | Resolved |
| Location | `src/ZB.MOM.WW.ScadaBridge.SiteRuntime/Actors/DeploymentManagerActor.cs:660-690` |
**Description**
@@ -1683,7 +1683,7 @@ Treat 'has a persisted deployed config' as present, not just 'in one of the two
**Resolution**
_Unresolved._
Resolved in commit `9ab1c002` (2026-06-24): replaced the `_totalDeployedCount` int (gated on in-memory map presence) with an authoritative `_deployedInstanceNames` HashSet; the deployed/disabled health counts are derived from its size, so deleting a disabled instance (absent from both maps) now decrements correctly while a delete for a never-deployed instance is a no-op. Regression test `SR032_DeleteDisabledInstance_DecrementsDeployedCount` added.
### SiteRuntime-033 — Native-alarm doc stale re: per-condition eviction and cap return-to-normal
@@ -1691,7 +1691,7 @@ _Unresolved._
|--|--|
| Severity | Low |
| Category | Documentation & comments |
| Status | Open |
| Status | Resolved |
| Location | `docs/requirements/Component-SiteRuntime.md:272` |
**Description**
@@ -1704,4 +1704,4 @@ Update the Per-source cap bullet to note that an active evicted condition emits
**Resolution**
_Unresolved._
Resolved in commit `9ab1c002` (2026-06-24): updated `Component-SiteRuntime.md` — the per-source-cap bullet now documents the return-to-normal emit for an active evicted condition, and the reset-semantics bullet documents per-condition `_latestAlarmEvents` eviction via `NativeAlarmDropped` (snapshot-swap / retention drop / cap eviction), not only redeploy/undeploy.