docs(code-review): resolve the 8 re-review findings (fixed in 9ab1c002)

Flip DataConnectionLayer-029, InboundAPI-031, SiteRuntime-032/033,
StoreAndForward-028, AuditLog-017, CentralUI-037, ScriptAnalysis-009 from Open to
Resolved with the fixing commit + a one-line resolution each; regen README
(0 pending / 576 total across 25 modules).
This commit is contained in:
Joseph Doherty
2026-06-24 09:40:47 -04:00
parent 9ab1c00265
commit ad4744a295
8 changed files with 37 additions and 47 deletions
+3 -3
View File
@@ -8,7 +8,7 @@
| Last reviewed | 2026-06-24 |
| Reviewer | claude-agent |
| Commit reviewed | `1f9de8a2` |
| Open findings | 1 |
| Open findings | 0 |
## Summary
@@ -1663,7 +1663,7 @@ Focused re-review of the changes since the prior review — verifying the code-r
|--|--|
| Severity | Medium |
| Category | Correctness & logic bugs |
| Status | Open |
| Status | Resolved |
| Location | `src/ZB.MOM.WW.ScadaBridge.InboundAPI/RouteHelper.cs:266` |
**Description**
@@ -1676,4 +1676,4 @@ Align the local backstop with the round-trip slack the CommunicationService Ask
**Resolution**
_Unresolved._
Resolved in commit `9ab1c002` (2026-06-24): removed `WaitForAttribute`'s local `timeout + 5s` backstop CTS; the wait now links only the client-abort and explicit caller tokens and relies on `CommunicationService.RouteToWaitForAttributeAsync`'s `timeout + IntegrationTimeout` Ask bound as the authoritative round-trip backstop, so a slow-but-valid timed-out response returns `false` rather than being cancelled into a 500. Regression test `WaitForAttribute_SlowTimedOutResponse_NotPreemptedByLocalBackstop` added.