docs(code-review): resolve the 8 re-review findings (fixed in 9ab1c002)
Flip DataConnectionLayer-029, InboundAPI-031, SiteRuntime-032/033, StoreAndForward-028, AuditLog-017, CentralUI-037, ScriptAnalysis-009 from Open to Resolved with the fixing commit + a one-line resolution each; regen README (0 pending / 576 total across 25 modules).
This commit is contained in:
@@ -8,7 +8,7 @@
|
||||
| Last reviewed | 2026-06-24 |
|
||||
| Reviewer | claude-agent |
|
||||
| Commit reviewed | `1f9de8a2` |
|
||||
| Open findings | 1 |
|
||||
| Open findings | 0 |
|
||||
|
||||
## Summary
|
||||
|
||||
@@ -1534,7 +1534,7 @@ Focused re-review of the changes since the prior review — verifying the code-r
|
||||
|--|--|
|
||||
| Severity | Medium |
|
||||
| Category | Correctness & logic bugs |
|
||||
| Status | Open |
|
||||
| Status | Resolved |
|
||||
| Location | `src/ZB.MOM.WW.ScadaBridge.DataConnectionLayer/Actors/DataConnectionActor.cs:1823` |
|
||||
|
||||
**Description**
|
||||
@@ -1547,4 +1547,4 @@ In HandleAlarmSubscribeCompleted, before storing the subscription id, guard agai
|
||||
|
||||
**Resolution**
|
||||
|
||||
_Unresolved._
|
||||
Resolved in commit `9ab1c002` (2026-06-24): `HandleAlarmSubscribeCompleted` now guards the `_alarmSubscriptionIds` store — when a feed is already present for the source, the redundant just-created subscription is released via `UnsubscribeAlarmsAsync` instead of overwriting the stored id (mirroring the tag-path re-check). Regression test `DCL029_ResubscribeDuringOrphanedInFlightSubscribe_ReleasesDuplicateFeed_NoLeak` added.
|
||||
|
||||
Reference in New Issue
Block a user