feat(central-ui): FlowGraphView log-count badge and exception subtitle on failed nodes (D8)

2026-09-09 11:36:42 -04:00
parent 25b127b3e3
commit a4a35bfa97
4 changed files with 232 additions and 16 deletions
@@ -566,4 +566,124 @@ public class FlowGraphViewTests : BunitContext
        var edge = Assert.Single(layout.Edges);
        Assert.True(edge.Async);
    }
+
+    // ── Step logs + exception subtitle (step-logs plan 2026-09-09, D8) ──
+
+    private static FlowLogLine Line(string level, string message = "m", int seq = 0)
+        => new(Guid.NewGuid(), Root, T0.AddMilliseconds(seq), level, "script", message, null, null, null, seq);
+
+    /// <summary>A one-node Site-lane graph whose single step carries the given logs / error shape.</summary>
+    private static FlowGraph LogGraph(
+        FlowStepOutcome outcome = FlowStepOutcome.Ok,
+        string? errorMessage = null,
+        string? errorDetail = null,
+        IReadOnlyList<FlowLogLine>? logs = null)
+    {
+        var step = new FlowStep(Guid.NewGuid(), Root, null, FlowStepKind.ScriptRun, FlowLane.Site, "DoWork", "trigger: manual",
+            T0, 5, outcome, null, null, errorMessage, "site-a", "node-a", "M1", "DoWork", null, null, null, errorDetail, logs);
+        return new FlowGraph([step], [], false, false);
+    }
+
+    [Fact]
+    public void Render_StepWithNoLogLines_HasNoLogBadge()
+    {
+        var cut = Render<FlowGraphView>(p => p.Add(c => c.Graph, LogGraph()));
+
+        Assert.Empty(cut.FindAll("[data-test='flow-node-logs']"));
+        // The footer still exists and holds the subtitle.
+        Assert.NotNull(cut.Find("g[data-test='flow-node'] .fg-foot [data-test='flow-node-subtitle']"));
+    }
+
+    [Fact]
+    public void Render_StepWithMixedLevels_ShowsCountsHighestSeverityFirst_DebugCountedAsInfo()
+    {
+        var logs = new List<FlowLogLine>
+        {
+            Line("error"), Line("warn"), Line("WARN"), Line("info"), Line("info"), Line("info"), Line("debug"),
+        };
+
+        var cut = Render<FlowGraphView>(p => p.Add(c => c.Graph, LogGraph(logs: logs)));
+
+        var badge = cut.Find("[data-test='flow-node-logs']");
+        Assert.Equal(["✕ 1", "! 2", "≡ 4"], badge.QuerySelectorAll("i").Select(i => i.TextContent.Trim()));
+        Assert.Equal(["e", "w", "i"], badge.QuerySelectorAll("i").Select(i => i.GetAttribute("class")));
+        Assert.Equal("1 error, 2 warnings, 4 info", badge.GetAttribute("title"));
+    }
+
+    [Fact]
+    public void Render_StepWithOnlyInfoLines_ShowsASingleFaintCount()
+    {
+        var cut = Render<FlowGraphView>(p => p.Add(c => c.Graph, LogGraph(logs: [Line("info"), Line("debug")])));
+
+        var badge = cut.Find("[data-test='flow-node-logs']");
+        var item = Assert.Single(badge.QuerySelectorAll("i"));
+        Assert.Equal("≡ 2", item.TextContent.Trim());
+        Assert.Equal("i", item.GetAttribute("class"));
+        Assert.Equal("2 info", badge.GetAttribute("title"));
+    }
+
+    [Fact]
+    public void Render_FailedStepWithErrorDetail_SubtitleIsTheExceptionTypeAndMessage()
+    {
+        var graph = LogGraph(FlowStepOutcome.Failed, errorMessage: "Recipe 42 rejected",
+            errorDetail: "System.InvalidOperationException: Recipe 42 rejected\n   at X");
+
+        var cut = Render<FlowGraphView>(p => p.Add(c => c.Graph, graph));
+
+        Assert.Equal("InvalidOperationException: Recipe 42 rejected",
+            cut.Find("[data-test='flow-node-subtitle']").TextContent.Trim());
+    }
+
+    [Fact]
+    public void Render_FailedStepWithoutDetail_FallsBackToTheErrorMessage()
+    {
+        var cut = Render<FlowGraphView>(p => p.Add(c => c.Graph, LogGraph(FlowStepOutcome.Failed, errorMessage: "timed out talking to MesDb")));
+
+        Assert.Equal("timed out talking to MesDb", cut.Find("[data-test='flow-node-subtitle']").TextContent.Trim());
+    }
+
+    [Fact]
+    public void Render_OkStepWithAnErrorDetail_KeepsItsNormalSubtitle()
+    {
+        var cut = Render<FlowGraphView>(p => p.Add(c => c.Graph, LogGraph(errorDetail: "System.InvalidOperationException: stale")));
+
+        Assert.Equal("trigger: manual", cut.Find("[data-test='flow-node-subtitle']").TextContent.Trim());
+    }
+
+    [Fact]
+    public void LogCounts_FoldsLevelsCaseInsensitively_AndTreatsEverythingElseAsInfo()
+    {
+        Assert.Equal((0, 0, 0), FlowGraphView.LogCounts(null));
+        Assert.Equal((0, 0, 0), FlowGraphView.LogCounts(LogGraph().Steps[0]));
+
+        var step = LogGraph(logs: [Line("Error"), Line("error"), Line("Warn"), Line("info"), Line("debug"), Line("trace")]).Steps[0];
+        Assert.Equal((2, 1, 3), FlowGraphView.LogCounts(step));
+    }
+
+    [Theory]
+    [InlineData(FlowStepOutcome.Failed, "System.InvalidOperationException: Recipe 42 rejected\n   at X", "boom", "InvalidOperationException: Recipe 42 rejected")]
+    [InlineData(FlowStepOutcome.TimedOut, "System.TimeoutException: took too long", "boom", "TimeoutException: took too long")]
+    [InlineData(FlowStepOutcome.Failed, "SomethingWentWrong", "boom", "SomethingWentWrong")]
+    [InlineData(FlowStepOutcome.Failed, "  ", "boom", "boom")]
+    [InlineData(FlowStepOutcome.Failed, null, "boom", "boom")]
+    [InlineData(FlowStepOutcome.Ok, "System.InvalidOperationException: nope", "boom", null)]
+    public void ExceptionSubtitle_ParsesTheFirstLineOfTheDetail_OnlyForAFailedStep(
+        FlowStepOutcome outcome, string? detail, string? message, string? expected)
+    {
+        var step = LogGraph(outcome, errorMessage: message, errorDetail: detail).Steps[0];
+
+        Assert.Equal(expected, FlowGraphView.ExceptionSubtitle(step));
+    }
+
+    [Fact]
+    public void LogTitle_NamesOnlyTheNonZeroLevels_WithSingularAndPlural()
+    {
+        FlowLayoutNode Node(IReadOnlyList<FlowLogLine>? logs)
+            => new("k", FlowLane.Site, 0, 0, 0, LogGraph(logs: logs).Steps[0], null, false);
+
+        Assert.Equal("1 error", FlowGraphView.LogTitle(Node([Line("error")])));
+        Assert.Equal("2 errors, 1 warning", FlowGraphView.LogTitle(Node([Line("error"), Line("error"), Line("warn")])));
+        Assert.Equal("1 warning, 2 info", FlowGraphView.LogTitle(Node([Line("warn"), Line("info"), Line("debug")])));
+        Assert.Equal(string.Empty, FlowGraphView.LogTitle(Node(null)));
+    }
 }