perf(misc): cached hot-path lookups, bounded observer queue, alarm-priority stream path

WP2.6 (arch-review remediation, cross-cutting misc): - SiteExternalSystemRepository: name/ID-indexed ExternalSystemDefinitionCache replaces the fetch-all + reverse-map scan on every by-ID/method lookup; loaded once per redeploy, invalidated by DeploymentManagerActor after HandleDeployArtifacts applies external-system changes. Static JsonSerializerOptions for method-list parsing. - Inbound API: short-TTL ApiMethodCache fronts the per-request ApiMethod repository fetch; invalidated by name via the existing ScriptArtifactChangeSubscriber/ IScriptArtifactChangeBus pipeline, self-healing via TTL for changes the bus doesn't cover (e.g. Management API edits). - StoreAndForward: the cached-call audit-observer queue — the one unbounded channel left in the system — is now bounded (ObserverQueueCapacity, default 10,000) with DropOldest overflow and a dropped-notification counter. - SiteStreamManager: alarm state changes now travel a dedicated publish source/broadcast hub, isolated from the (far higher-volume) attribute path, so an attribute storm can no longer evict a pending alarm transition; the alarm hand-off queue is bounded with a drop counter surfaced on the site health report (SiteStreamAlarmDropCount via the new SiteStreamAlarmDropReporter), and publishing is skipped entirely at zero subscribers on either path. - CLI ManagementHttpClient: explicit 30s HttpClient.Timeout on the shared construction (was the 100s framework default), overridable via SCADABRIDGE_HTTP_TIMEOUT_SECONDS. Deviation: the failback-probe heartbeat item is NOT included — its only viable surface (CentralChannelProvider.cs / heartbeat consumers) lives entirely in the Communication project, explicitly off-limits to this work package this phase. Tests: SiteRuntime.Tests (550), InboundAPI.Tests (278), StoreAndForward.Tests (133), CLI.Tests (390), HealthMonitoring.Tests (97) — all green after full solution build.
2026-08-14 20:59:43 -04:00
parent ee193cd2bb
commit a212283104
32 changed files with 1361 additions and 111 deletions
@@ -104,3 +104,78 @@ public class ManagementHttpClientTests
        Assert.Equal("TIMEOUT", response.ErrorCode);
    }
 }
+
+/// <summary>
+/// WP2.6e (arch-review misc — CLI HttpClient timeout): the public
+/// <see cref="ManagementHttpClient"/> constructor must bound its underlying
+/// <see cref="HttpClient.Timeout"/> explicitly (30 s default) rather than leaving the
+/// framework's 100 s default in place, and must honor the
+/// <c>SCADABRIDGE_HTTP_TIMEOUT_SECONDS</c> override — consistent with how every other
+/// CLI setting is environment-overridable (<see cref="CliConfig"/>). Runs in the shared
+/// "Environment" collection (see <see cref="TestCollections"/>) so it never races another
+/// test mutating process-wide environment variables.
+/// </summary>
+[Collection("Environment")]
+public class ManagementHttpClientTimeoutTests
+{
+    private const string EnvVar = "SCADABRIDGE_HTTP_TIMEOUT_SECONDS";
+
+    [Fact]
+    public void DefaultConstructor_SetsThirtySecondTimeout_WhenEnvVarUnset()
+    {
+        var original = Environment.GetEnvironmentVariable(EnvVar);
+        try
+        {
+            Environment.SetEnvironmentVariable(EnvVar, null);
+
+            using var client = new ManagementHttpClient("http://localhost:9001", "user", "pass");
+
+            Assert.Equal(TimeSpan.FromSeconds(30), ManagementHttpClient.DefaultTimeout);
+            Assert.Equal(TimeSpan.FromSeconds(30), client.EffectiveTimeout);
+        }
+        finally
+        {
+            Environment.SetEnvironmentVariable(EnvVar, original);
+        }
+    }
+
+    [Theory]
+    [InlineData("0")]
+    [InlineData("-5")]
+    [InlineData("not-a-number")]
+    [InlineData("")]
+    public void InvalidOrNonPositiveEnvValue_FallsBackToDefault(string value)
+    {
+        var original = Environment.GetEnvironmentVariable(EnvVar);
+        try
+        {
+            Environment.SetEnvironmentVariable(EnvVar, value);
+
+            using var client = new ManagementHttpClient("http://localhost:9001", "user", "pass");
+
+            Assert.Equal(TimeSpan.FromSeconds(30), client.EffectiveTimeout);
+        }
+        finally
+        {
+            Environment.SetEnvironmentVariable(EnvVar, original);
+        }
+    }
+
+    [Fact]
+    public void PositiveEnvValue_OverridesDefaultTimeout()
+    {
+        var original = Environment.GetEnvironmentVariable(EnvVar);
+        try
+        {
+            Environment.SetEnvironmentVariable(EnvVar, "5");
+
+            using var client = new ManagementHttpClient("http://localhost:9001", "user", "pass");
+
+            Assert.Equal(TimeSpan.FromSeconds(5), client.EffectiveTimeout);
+        }
+        finally
+        {
+            Environment.SetEnvironmentVariable(EnvVar, original);
+        }
+    }
+}