Resolve all 46 low-severity architecture review findings

tests/ZB.MOM.WW.ScadaBridge.SiteCallAudit.Tests/SiteCallAuditOptionsValidatorTests.cs

@@ -16,6 +16,14 @@ public class SiteCallAuditOptionsValidatorTests
     private static ValidateOptionsResult Validate(SiteCallAuditOptions options) =>
         new SiteCallAuditOptionsValidator().Validate(Options.DefaultName, options);
 
+    [Theory]
+    [InlineData(1, true)]
+    [InlineData(2000, true)]
+    [InlineData(2001, false)]
+    [InlineData(int.MaxValue, false)]
+    public void ReconciliationBatchSize_MatchesRpcCeiling(int size, bool valid)
+        => Assert.Equal(valid, Validate(new SiteCallAuditOptions { ReconciliationBatchSize = size }).Succeeded);
+
     [Fact]
     public void DefaultOptions_AreValid()
     {

tests/ZB.MOM.WW.ScadaBridge.SiteCallAudit.Tests/ZB.MOM.WW.ScadaBridge.SiteCallAudit.Tests.csproj

@@ -11,13 +11,8 @@
   <ItemGroup>
     <PackageReference Include="Akka.TestKit.Xunit2" />
     <PackageReference Include="coverlet.collector" />
-    <!--
-      MSSQL-backed SiteCallAuditActor tests use the MsSqlMigrationFixture
-      (reused from ConfigurationDatabase.Tests). Pinning 6.1.1 here mirrors
-      AuditLog.Tests: EF SqlServer 10.0.7 needs >= 6.1.1 but the central pin
-      is 6.0.2 (production ExternalSystemGateway). Override is test-only.
-    -->
-    <PackageReference Include="Microsoft.Data.SqlClient" VersionOverride="6.1.1" />
+    <!-- Use the central SqlClient pin, matching the production EF dependency floor. -->
+    <PackageReference Include="Microsoft.Data.SqlClient" />
     <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />