dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Resolve all 46 low-severity architecture review findings

Browse Source
This commit is contained in:
Joseph Doherty
2026-09-09 22:56:36 -04:00
parent fef3e7675f
commit 9ee402bbcd
139 changed files with 2621 additions and 1082 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.ConfigurationDatabase.Tests/TemplateEngineRepositoryTests.cs
+24
View File
@@ -29,6 +29,30 @@ public class TemplateEngineRepositoryTests : IDisposable
_context.Dispose();
}
[Fact]
public async Task TopologyPage_IsBoundedFilteredAndUntracked()
{
var site = new ZB.MOM.WW.ScadaBridge.Commons.Entities.Sites.Site("PageSite", "page-site");
var other = new ZB.MOM.WW.ScadaBridge.Commons.Entities.Sites.Site("OtherPageSite", "other-page-site");
var template = new Template("PageTemplate");
_context.Sites.AddRange(site, other);
_context.Templates.Add(template);
await _context.SaveChangesAsync();
_context.Instances.AddRange(Enumerable.Range(0, 101).Select(id =>
new ZB.MOM.WW.ScadaBridge.Commons.Entities.Instances.Instance($"Paged-{id:D3}") { SiteId = site.Id, TemplateId = template.Id }));
_context.Instances.Add(new ZB.MOM.WW.ScadaBridge.Commons.Entities.Instances.Instance("Other") { SiteId = other.Id, TemplateId = template.Id });
await _context.SaveChangesAsync();
_context.ChangeTracker.Clear();
var first = await _repository.GetTopologyInstancesAsync(site.Id, null, 0, 50);
var second = await _repository.GetTopologyInstancesAsync(site.Id, null, 50, 50);
Assert.Equal(50, first.Count);
Assert.Equal(50, second.Count);
Assert.All(first.Concat(second), i => Assert.Equal(site.Id, i.SiteId));
Assert.Empty(first.Select(i => i.Id).Intersect(second.Select(i => i.Id)));
Assert.Empty(_context.ChangeTracker.Entries());
await Assert.ThrowsAsync<ArgumentOutOfRangeException>(() => _repository.GetTopologyInstancesAsync(site.Id, null, 0, 51));
}
[Fact]
public async Task GetTemplateWithChildrenAsync_ReturnsTemplateWithAllMemberCollectionsPopulated()
{