Resolve all 46 low-severity architecture review findings

2026-09-09 22:56:36 -04:00
parent fef3e7675f
commit 9ee402bbcd
139 changed files with 2621 additions and 1082 deletions
@@ -52,6 +52,17 @@ public class FlowDebuggerPageTests : BunitContext
    ],
    [new("n1", "n2", false), new("n2", "n3", false)]);

+    [Fact]
+    public void RefreshMerge_UsesReplayOrderThenLiveOnlyRows()
+    {
+        var first = ScadaBridgeAuditEventFactory.Create(AuditChannel.ScriptTrace, AuditKind.ScriptRun, AuditStatus.Delivered);
+        var late = ScadaBridgeAuditEventFactory.Create(AuditChannel.ScriptTrace, AuditKind.ScriptRun, AuditStatus.Delivered);
+        var last = ScadaBridgeAuditEventFactory.Create(AuditChannel.ScriptTrace, AuditKind.ScriptRun, AuditStatus.Delivered);
+        var liveOnly = ScadaBridgeAuditEventFactory.Create(AuditChannel.ScriptTrace, AuditKind.ScriptRun, AuditStatus.Delivered);
+        var result = FlowDebuggerPage.MergeEvents([first, last, liveOnly], [first, late, last]);
+        Assert.Equal(new[] { first.EventId, late.EventId, last.EventId, liveOnly.EventId }, result.Select(e => e.EventId));
+    }
+
    private static FlowDebugOutcome GraphOutcome(bool withSite, bool withChildId)
    {
        var root = Guid.NewGuid();