Resolve all 46 low-severity architecture review findings

src/ZB.MOM.WW.ScadaBridge.SiteRuntime/Scripts/ScriptRuntimeContext.cs

@@ -411,7 +411,7 @@ public class ScriptRuntimeContext
         {
             // The collector is a debug-only observer: it must never fail a script call, and it
             // must never keep the durable audit row from reaching the writer (review, 2026-09-06).
-            _logger.LogWarning(ex, "Flow trace collector rejected {Action} ({EventId})", evt.Action, evt.EventId);
+            _innerLogger.LogWarning(ex, "Flow trace collector rejected {Action} ({EventId})", evt.Action, evt.EventId);
         }
     }
 
@@ -548,7 +548,7 @@ public class ScriptRuntimeContext
         }
         catch (Exception ex)
         {
-            _logger.LogWarning(ex, "Flow trace event build failed for {Kind}", kind);
+            _innerLogger.LogWarning(ex, "Flow trace event build failed for {Kind}", kind);
             return;
         }
 
@@ -560,7 +560,7 @@ public class ScriptRuntimeContext
             if (!t.IsCompletedSuccessfully)
             {
                 _ = t.ContinueWith(
-                    x => _logger.LogWarning(x.Exception, "Flow trace write failed for {Kind}", kind),
+                    x => _innerLogger.LogWarning(x.Exception, "Flow trace write failed for {Kind}", kind),
                     CancellationToken.None,
                     TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.ExecuteSynchronously,
                     TaskScheduler.Default);
@@ -568,7 +568,7 @@ public class ScriptRuntimeContext
         }
         catch (Exception ex)
         {
-            _logger.LogWarning(ex, "Flow trace write failed for {Kind}", kind);
+            _innerLogger.LogWarning(ex, "Flow trace write failed for {Kind}", kind);
         }
     }
 
@@ -1057,17 +1057,22 @@ public class ScriptRuntimeContext
         return result.ReturnValue;
     }
 
-    /// <summary>
-    /// Provides access to shared script execution via the Scripts property.
-    /// </summary>
-    public ScriptCallHelper Scripts => new(_sharedScriptLibrary, this, _currentCallDepth, _maxCallDepth, _logger);
+    private ScriptCallHelper? _scripts;
+    private ExternalSystemHelper? _externalSystem;
+    private DatabaseHelper? _database;
+    private NotifyHelper? _notify;
+    private AlarmsAccessor? _alarms;
+    private TrackingHelper? _tracking;
+
+    /// <summary>Provides access to shared script execution via a helper cached for this context.</summary>
+    public ScriptCallHelper Scripts => _scripts ??= new(_sharedScriptLibrary, this, _currentCallDepth, _maxCallDepth, _logger);
 
     /// <summary>
     /// Provides access to external system calls.
     /// ExternalSystem.Call("systemName", "methodName", params)
     /// ExternalSystem.CachedCall("systemName", "methodName", params)
     /// </summary>
-    public ExternalSystemHelper ExternalSystem => new(
+    public ExternalSystemHelper ExternalSystem => _externalSystem ??= new(
         _externalSystemClient, _instanceName, _logger, _executionId, _auditWriter, _siteId, _sourceScript,
         // Emit CachedSubmit telemetry
         // on every ExternalSystem.CachedCall enqueue.
@@ -1089,7 +1094,7 @@ public class ScriptRuntimeContext
     /// Database.Connection("name")
     /// Database.CachedWrite("name", "sql", params)
     /// </summary>
-    public DatabaseHelper Database => new(
+    public DatabaseHelper Database => _database ??= new(
         _databaseGateway,
         _instanceName,
         _logger,
@@ -1127,7 +1132,7 @@ public class ScriptRuntimeContext
     /// Best-effort per alog.md §7 — a thrown writer never aborts the script's
     /// <c>Send</c>.
     /// </remarks>
-    public NotifyHelper Notify => new(
+    public NotifyHelper Notify => _notify ??= new(
         _storeAndForward, _siteCommunicationActor, _siteId, _instanceName, _sourceScript, _askTimeout, _logger,
         _executionId, _auditWriter,
         // (ParentExecutionId): the spawning execution's id,
@@ -1146,7 +1151,7 @@ public class ScriptRuntimeContext
     /// Gateway) conditions alike — so a <c>Call</c> script can answer "what is in alarm
     /// right now?" without an on-trigger <c>Alarm</c> context.
     /// </summary>
-    public AlarmsAccessor Alarms => new(this);
+    public AlarmsAccessor Alarms => _alarms ??= new(this);
 
     /// <summary>
     /// Backing read for <see cref="AlarmsAccessor.CurrentAsync"/>: Asks THIS instance's
@@ -1210,7 +1215,7 @@ public class ScriptRuntimeContext
     /// returns a <see cref="TrackingStatusSnapshot"/>, or <c>null</c> when the
     /// id is unknown / has already been purged.
     /// </summary>
-    public TrackingHelper Tracking => new(_operationTrackingStore, _logger);
+    public TrackingHelper Tracking => _tracking ??= new(_operationTrackingStore, _logger);
 
     /// <summary>
     /// Helper class for Scripts.CallShared() syntax.