Resolve all 46 low-severity architecture review findings

src/ZB.MOM.WW.ScadaBridge.Communication/Grpc/SiteStreamGrpcClient.cs

@@ -82,6 +82,7 @@ public class SiteStreamGrpcClient : IAsyncDisposable, IDisposable
         ISitePskProvider? pskProvider,
         string? siteIdentifier)
     {
+        ConnectedHeaderTimeout = options.ConnectedHeaderTimeout;
         Endpoint = endpoint;
         KeepAlivePingDelay = options.GrpcKeepAlivePingDelay;
         KeepAlivePingTimeout = options.GrpcKeepAlivePingTimeout;
@@ -122,7 +123,12 @@ public class SiteStreamGrpcClient : IAsyncDisposable, IDisposable
     /// Unsubscribe and Dispose behavior without needing a real endpoint.
     /// </summary>
     /// <returns>A <see cref="SiteStreamGrpcClient"/> with no channel or client, for testing only.</returns>
-    internal static SiteStreamGrpcClient CreateForTesting() => new();
+    internal static SiteStreamGrpcClient CreateForTesting(CommunicationOptions? options = null) => new(options ?? new CommunicationOptions());
+
+    private SiteStreamGrpcClient(CommunicationOptions options)
+    {
+        ConnectedHeaderTimeout = options.ConnectedHeaderTimeout;
+    }
 
     /// <summary>
     /// Registers a CancellationTokenSource for a correlation ID. Test-only.
@@ -457,7 +463,7 @@ public class SiteStreamGrpcClient : IAsyncDisposable, IDisposable
     /// with its first message would otherwise hold the connected signal — and with it the
     /// aggregator's re-seed — for as long as the site happens to be quiet.
     /// </summary>
-    internal static TimeSpan ConnectedHeaderTimeout { get; set; } = TimeSpan.FromSeconds(10);
+    internal TimeSpan ConnectedHeaderTimeout { get; } = TimeSpan.FromSeconds(10);
 
     /// <summary>
     /// Awaits the call's response headers, bounded by <see cref="ConnectedHeaderTimeout"/>.
@@ -475,7 +481,7 @@ public class SiteStreamGrpcClient : IAsyncDisposable, IDisposable
     /// timeout was added for is covered by the reconcile backstop.
     /// </para>
     /// </summary>
-    private static async Task<bool> AwaitHeadersAsync(
+    private async Task<bool> AwaitHeadersAsync(
         AsyncServerStreamingCall<SiteStreamEvent> call, CancellationToken ct)
     {
         var headers = call.ResponseHeadersAsync;