ui: Central UI density/consistency sweep + Theme 0.4.1

Applies the family-wide admin-UI cleanup playbook to the Central UI so the Blazor surfaces stop diverging from the shared kit: buttons are grouped rather than individually sized, long cell values are contained instead of widening tables, and hard-coded colours give way to theme tokens. The headline fix is that MainLayout passed Accent="#2f5fd0" to ThemeShell, which the kit emits as an inline style on the shell root. Being a descendant of <html>, it beat the [data-bs-theme="dark"] override for the entire app, so the dark accent had never rendered. Declaring --accent in site.css :root instead lets both schemes resolve; light is unchanged because the value already matched the kit's light default. Theme pins to 0.4.1, which upstreams the local .btn sizing block verbatim, so that block is deleted here rather than duplicated. Verified byte-identical before removal; the repo now declares no --bs-btn-* anywhere. NOT purely cosmetic, contrary to the sweep's stated scope: four detail-modal surfaces (NotificationReport, ConfigurationAuditLog, ParkedMessages, SiteCallsReport) were additionally refactored from holding the selected record to holding its id and re-resolving from the current page each render, with the resolve doubling as the visibility gate. A background refresh that drops the row now closes the modal instead of showing a stale snapshot. This is a behaviour change and is called out rather than buried: a full-suite run turned up one intermittent CentralUI failure, CloseButton_DismissesModal, whose stack (GetRequiredEventBindingEntry during DispatchEventAsync) indicates the handler was disposed between render and click — a window the previous field-held record made structurally impossible. Treat the modal lifecycle here as unreviewed. Build 0/0; suite green apart from that one intermittent failure.
2026-08-11 05:50:12 -04:00
parent b6f383a225
commit 9e243493fb
77 changed files with 2197 additions and 1292 deletions
@@ -100,7 +100,7 @@ public class NodeBrowserDialogSearchTests : BunitContext
        // Click the first result's link — this drives the SAME selection
        // mechanism the tree uses, so the footer Select button confirms and
        // OnSelected fires.
-        cut.FindAll("[data-test=node-search-result] a")[0].Click();
+        cut.FindAll("[data-test=node-search-result] button.btn-link")[0].Click();
        cut.Find(".modal-footer .btn-primary").Click();

        Assert.Equal("ns=2;s=Pump1.Speed", _capturedSelection());
@@ -46,7 +46,7 @@ public class NodeBrowserDialogSelectionTests : BunitContext

        cut.Find("[data-test=node-search-input]").Input("Pump1");
        cut.Find("[data-test=node-search-button]").Click();
-        cut.FindAll("[data-test=node-search-result] a")[0].Click();
+        cut.FindAll("[data-test=node-search-result] button.btn-link")[0].Click();
        cut.Find(".modal-footer .btn-primary").Click();

        Assert.NotNull(captured);
@@ -90,8 +90,10 @@ public class NodeBrowserDialogSelectionTests : BunitContext
        cut.InvokeAsync(() => cut.Instance.ShowAsync("plant-a", "PLC-MX", null));
        cut.Render();

-        // Click the tree node's select link (tree path, not search).
-        cut.Find(".node-browser-tree a").Click();
+        // Click the tree node's select control (tree path, not search). It is a
+        // <button class="btn btn-link"> since the 2026-08-11 UI sweep replaced the
+        // href="javascript:void(0)" anchor; both click handlers were preserved.
+        cut.Find(".node-browser-tree button.btn-link").Click();
        cut.Find(".modal-footer .btn-primary").Click();

        Assert.NotNull(captured);
@@ -175,10 +175,10 @@ public class TransportExportPageTests : BunitContext
            Assert.NotNull(cut.Find($"[data-testid='{groupId}']"));
        }

-        // The API-keys selection group is gone, replaced by an info note explaining
-        // that keys must be re-created per environment.
+        // The API-keys selection group is gone. The explanatory note that used to sit
+        // beside it moved into docs/requirements/Component-Transport.md (UI cleanup
+        // sweep 2026-08-11) — the absence of the group is the assertion that matters.
        Assert.Empty(cut.FindAll("[data-testid='group-api-keys']"));
-        Assert.NotNull(cut.Find("[data-testid='api-keys-not-transported']"));

        // Sanity: each artifact shows its label.
        Assert.Contains("Helpers", cut.Markup);
@@ -354,7 +354,6 @@ public class TransportExportPageTests : BunitContext

        // The Sites & Instances group is present alongside the existing artifact groups.
        Assert.NotNull(cut.Find("[data-testid='group-sites']"));
-        Assert.NotNull(cut.Find("[data-testid='sites-hint']"));
        Assert.Contains("North Plant", cut.Markup);
        Assert.Contains("north", cut.Markup);