dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

ui: Central UI density/consistency sweep + Theme 0.4.1

Browse Source 
Applies the family-wide admin-UI cleanup playbook to the Central UI so the
Blazor surfaces stop diverging from the shared kit: buttons are grouped rather
than individually sized, long cell values are contained instead of widening
tables, and hard-coded colours give way to theme tokens.

The headline fix is that MainLayout passed Accent="#2f5fd0" to ThemeShell,
which the kit emits as an inline style on the shell root. Being a descendant of
<html>, it beat the [data-bs-theme="dark"] override for the entire app, so the
dark accent had never rendered. Declaring --accent in site.css :root instead
lets both schemes resolve; light is unchanged because the value already matched
the kit's light default.

Theme pins to 0.4.1, which upstreams the local .btn sizing block verbatim, so
that block is deleted here rather than duplicated. Verified byte-identical
before removal; the repo now declares no --bs-btn-* anywhere.

NOT purely cosmetic, contrary to the sweep's stated scope: four detail-modal
surfaces (NotificationReport, ConfigurationAuditLog, ParkedMessages,
SiteCallsReport) were additionally refactored from holding the selected record
to holding its id and re-resolving from the current page each render, with the
resolve doubling as the visibility gate. A background refresh that drops the
row now closes the modal instead of showing a stale snapshot. This is a
behaviour change and is called out rather than buried: a full-suite run turned
up one intermittent CentralUI failure, CloseButton_DismissesModal, whose stack
(GetRequiredEventBindingEntry during DispatchEventAsync) indicates the handler
was disposed between render and click — a window the previous field-held record
made structurally impossible. Treat the modal lifecycle here as unreviewed.

Build 0/0; suite green apart from that one intermittent failure.
This commit is contained in:
Joseph Doherty
2026-08-11 05:50:12 -04:00
parent b6f383a225
commit 9e243493fb
77 changed files with 2197 additions and 1292 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Design/TemplateCrudTests.cs
+9 -6
View File
@@ -79,8 +79,10 @@ public class TemplateCrudTests : IClassFixture<DeploymentFixture>
// The select is label-anchored: <label>Data Type</label> + <select class="form-select">.
await modal.Locator("div.col-12:has(label:has-text('Data Type')) select.form-select").SelectOptionAsync("Double");
// Click the footer Add button (btn-success btn-sm, text "Add").
await modal.Locator(".modal-footer button.btn-success.btn-sm:has-text('Add')").ClickAsync();
// Click the footer Add button (btn-success, text "Add"). The dialog feet were
// wrapped in a btn-group btn-group-sm by the 2026-08-11 UI sweep, so the size
// class now lives on the group rather than on the button itself.
await modal.Locator(".modal-footer button.btn-success:has-text('Add')").ClickAsync();
// The modal should dismiss and the attribute table should show "Val".
await Assertions.Expect(modal).ToHaveCountAsync(0, new() { Timeout = 10_000 });
@@ -89,7 +91,7 @@ public class TemplateCrudTests : IClassFixture<DeploymentFixture>
// ── DELETE ────────────────────────────────────────────────────────────────
// Click the header Delete button (btn-outline-danger btn-sm, text "Delete").
await page.ClickAsync("button.btn.btn-outline-danger.btn-sm:has-text('Delete')");
await page.ClickAsync("button.btn.btn-outline-danger:has-text('Delete')");
// The global DialogHost renders a confirm dialog.
// The danger confirm button carries class "btn-danger" and text "Delete".
@@ -258,8 +260,9 @@ public class TemplateCrudTests : IClassFixture<DeploymentFixture>
var valueInput = modal.Locator("div.col-12:has(label:has-text('Value')) input.form-control");
await valueInput.FillAsync("42.5");
// Footer button text is "Save" when editing (vs "Add" when adding).
await modal.Locator(".modal-footer button.btn-success.btn-sm:has-text('Save')").ClickAsync();
// Footer button text is "Save" when editing (vs "Add" when adding). Size class
// sits on the enclosing btn-group-sm since the 2026-08-11 UI sweep.
await modal.Locator(".modal-footer button.btn-success:has-text('Save')").ClickAsync();
// SaveAttribute persists then reloads, dismissing the modal.
await Assertions.Expect(modal).ToHaveCountAsync(0, new() { Timeout = 10_000 });
@@ -306,7 +309,7 @@ public class TemplateCrudTests : IClassFixture<DeploymentFixture>
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
// Header Delete button (btn-outline-danger btn-sm).
await page.ClickAsync("button.btn.btn-outline-danger.btn-sm:has-text('Delete')");
await page.ClickAsync("button.btn.btn-outline-danger:has-text('Delete')");
// Confirm via the global DialogHost modal's danger button (labelled
// "Delete"). This modal HAS the `fade` class — distinct from the