dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

ui: Central UI density/consistency sweep + Theme 0.4.1

Browse Source 
Applies the family-wide admin-UI cleanup playbook to the Central UI so the
Blazor surfaces stop diverging from the shared kit: buttons are grouped rather
than individually sized, long cell values are contained instead of widening
tables, and hard-coded colours give way to theme tokens.

The headline fix is that MainLayout passed Accent="#2f5fd0" to ThemeShell,
which the kit emits as an inline style on the shell root. Being a descendant of
<html>, it beat the [data-bs-theme="dark"] override for the entire app, so the
dark accent had never rendered. Declaring --accent in site.css :root instead
lets both schemes resolve; light is unchanged because the value already matched
the kit's light default.

Theme pins to 0.4.1, which upstreams the local .btn sizing block verbatim, so
that block is deleted here rather than duplicated. Verified byte-identical
before removal; the repo now declares no --bs-btn-* anywhere.

NOT purely cosmetic, contrary to the sweep's stated scope: four detail-modal
surfaces (NotificationReport, ConfigurationAuditLog, ParkedMessages,
SiteCallsReport) were additionally refactored from holding the selected record
to holding its id and re-resolving from the current page each render, with the
resolve doubling as the visibility gate. A background refresh that drops the
row now closes the modal instead of showing a stale snapshot. This is a
behaviour change and is called out rather than buried: a full-suite run turned
up one intermittent CentralUI failure, CloseButton_DismissesModal, whose stack
(GetRequiredEventBindingEntry during DispatchEventAsync) indicates the handler
was disposed between render and click — a window the previous field-held record
made structurally impossible. Treat the modal lifecycle here as unreviewed.

Build 0/0; suite green apart from that one intermittent failure.
This commit is contained in:
Joseph Doherty
2026-08-11 05:50:12 -04:00
parent b6f383a225
commit 9e243493fb
77 changed files with 2197 additions and 1292 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Admin/LdapMappingCrudTests.cs
+5 -5
View File
@@ -43,7 +43,7 @@ public class LdapMappingCrudTests
// violation. The LdapMappingForm.razor uses Blazor @bind, not <form>,
// so the "Role" label's parent div.mb-2 is the tightest stable scope.
await page.Locator("div.mb-2:has(label:has-text('Role')) .form-select.form-select-sm").SelectOptionAsync("Designer");
await page.ClickAsync("button.btn.btn-success.btn-sm:has-text('Save')");
await page.ClickAsync("button.btn.btn-success:has-text('Save')");
// Wait for Blazor enhanced navigation back to the list page.
await PlaywrightFixture.WaitForPathAsync(page, "/admin/ldap-mappings", excludePath: "/create");
@@ -62,7 +62,7 @@ public class LdapMappingCrudTests
// Change the role to Viewer and save.
await page.Locator("div.mb-2:has(label:has-text('Role')) .form-select.form-select-sm").SelectOptionAsync("Viewer");
await page.ClickAsync("button.btn.btn-success.btn-sm:has-text('Save')");
await page.ClickAsync("button.btn.btn-success:has-text('Save')");
await PlaywrightFixture.WaitForPathAsync(page, "/admin/ldap-mappings", excludePath: "/edit");
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
@@ -148,7 +148,7 @@ public class LdapMappingCrudTests
// FIRST in SaveMapping) is unambiguously the one that fires.
await page.Locator("div.mb-2:has(label:has-text('Role')) .form-select.form-select-sm")
.SelectOptionAsync("Designer");
await page.ClickAsync("button.btn.btn-success.btn-sm:has-text('Save')");
await page.ClickAsync("button.btn.btn-success:has-text('Save')");
await Assertions.Expect(page.Locator("div.text-danger.small.mt-2"))
.ToHaveTextAsync("LDAP Group Name is required.");
@@ -162,7 +162,7 @@ public class LdapMappingCrudTests
.FillAsync(group);
await page.Locator("div.mb-2:has(label:has-text('Role')) .form-select.form-select-sm")
.SelectOptionAsync(new[] { "" });
await page.ClickAsync("button.btn.btn-success.btn-sm:has-text('Save')");
await page.ClickAsync("button.btn.btn-success:has-text('Save')");
await Assertions.Expect(page.Locator("div.text-danger.small.mt-2"))
.ToHaveTextAsync("Role is required.");
@@ -200,7 +200,7 @@ public class LdapMappingCrudTests
.FillAsync(group);
await page.Locator("div.mb-2:has(label:has-text('Role')) .form-select.form-select-sm")
.SelectOptionAsync("Viewer");
await page.ClickAsync("button.btn.btn-success.btn-sm:has-text('Save')");
await page.ClickAsync("button.btn.btn-success:has-text('Save')");
// The catch block prefixes the raw DB message with "Save failed:" — assert
// only on that stable prefix, never the provider-specific tail.