refactor(ui): prioritize permitted operational views and touch topology

This commit is contained in:
Joseph Doherty
2026-11-13 19:24:12 -05:00
parent 0c41b613ac
commit 9dbfe7bcaf
70 changed files with 13050 additions and 96 deletions
@@ -755,6 +755,60 @@ public class HealthPageTests : BunitContext
});
}
/// <summary>Actionable observations precede healthy entries and use stable display-name ordering.</summary>
[Fact]
public void SiteCards_PrioritizeOfflineThenWarningsAndMissingReports()
{
var now = DateTimeOffset.UtcNow;
SiteHealthState Observed(string id, bool online = true, bool stale = false) => new()
{
SiteId = id, IsOnline = online, IsMetricsStale = stale,
LastHeartbeatAt = now, LastReportReceivedAt = now,
LatestReport = ReportWithReconciler(id, true)
};
SeedStates(Observed("healthy-a"), Observed("offline-z", false), Observed("warning-b", stale: true),
Observed("offline-a", false), new SiteHealthState { SiteId = "unknown", IsOnline = true, LastHeartbeatAt = now });
var cut = RenderHealthPage();
cut.WaitForAssertion(() => Assert.Equal(
new[] { "offline-a", "offline-z", "warning-b", "unknown", "healthy-a" },
cut.FindAll("[data-site-id]").Select(e => e.GetAttribute("data-site-id")).ToArray()));
}
/// <summary>Within a priority group, display name wins over machine-id order.</summary>
[Fact]
public void SiteCards_UseDisplayNameThenStableIdentifierWithinPriority()
{
var repo = Substitute.For<ISiteRepository>();
repo.GetAllSitesAsync(Arg.Any<CancellationToken>()).Returns(Task.FromResult<IReadOnlyList<Site>>([
new("Zulu", "a-id"), new("Alpha", "z-id"), new("Alpha", "b-id")]));
Services.AddSingleton(repo);
SeedStates(new SiteHealthState { SiteId = "a-id", IsOnline = false },
new SiteHealthState { SiteId = "z-id", IsOnline = false },
new SiteHealthState { SiteId = "b-id", IsOnline = false });
var cut = RenderHealthPage();
cut.WaitForAssertion(() => Assert.Equal(new[] { "b-id", "z-id", "a-id" },
cut.FindAll("[data-site-id]").Select(e => e.GetAttribute("data-site-id")).ToArray()));
}
/// <summary>Heartbeat-only sites retain known liveness but never claim observed healthy metrics.</summary>
[Fact]
public void MissingReport_IsUnknownAndIntervalErrorsAreNamedHonestly()
{
SeedStates(new SiteHealthState { SiteId = "heartbeat-only", IsOnline = true, LastHeartbeatAt = DateTimeOffset.UtcNow },
new SiteHealthState { SiteId = "observed", IsOnline = true, LastHeartbeatAt = DateTimeOffset.UtcNow,
LatestReport = ReportWithReconciler("observed", true) with { ScriptErrorCount = 2 } });
var cut = RenderHealthPage();
cut.WaitForAssertion(() =>
{
var unknown = cut.Find("[data-site-id='heartbeat-only']");
Assert.Contains("Metrics unknown", unknown.TextContent);
Assert.Contains("Online", unknown.TextContent);
Assert.DoesNotContain("Offline", unknown.TextContent);
Assert.Contains("Sites with errors in last report interval", cut.Markup);
Assert.DoesNotContain("Sites with active errors", cut.Markup);
});
}
// Re-seeds the aggregator substitute with fully-specified states (as opposed
// to SeedSites' minimal online placeholders).
private void SeedStates(params SiteHealthState[] states)