fix(dcl): identify MxGateway native alarms by object-relative reference

Surface native (Galaxy/MxGateway) alarms by their object-relative reference (e.g. "Z28061.HeartbeatTimeoutAlarm") instead of the gateway's full provider reference ("Galaxy!<area>.<object>.<alarm>"). The area is already preserved in Category and the object reference is globally unique within the galaxy, so the full provider prefix added only noise to the alarm identity operators see. MxGatewayAlarmMapper.MapTransition/MapSnapshot now set SourceReference from SourceObjectReference, falling back to AlarmFullReference only when the gateway omits the object reference. +2 mapper tests; full DCL suite green (158).
2026-06-16 19:46:44 -04:00
parent 361e7f41ba
commit 9b78e6071d
2 changed files with 60 additions and 2 deletions
@@ -65,6 +65,54 @@ public class MxGatewayAlarmMapperTests
        Assert.Equal(1000, t.Condition.Severity);
    }

+    [Fact]
+    public void SourceReference_IsObjectRelative_NotFullProviderReference()
+    {
+        // The condition identity surfaced upward is the object-relative reference
+        // (e.g. "Z28061.HeartbeatTimeoutAlarm"), not the gateway's full provider
+        // reference ("Galaxy!<area>.<object>.<alarm>"). Area lives in Category.
+        var snap = new ActiveAlarmSnapshot
+        {
+            AlarmFullReference = "Galaxy!CVDAisle_1.Z28061.HeartbeatTimeoutAlarm",
+            SourceObjectReference = "Z28061.HeartbeatTimeoutAlarm",
+            AlarmTypeName = "Syst",
+            Category = "CVDAisle_1",
+            CurrentState = ProtoConditionState.Active,
+            Severity = 400
+        };
+        var ev = new OnAlarmTransitionEvent
+        {
+            AlarmFullReference = "Galaxy!CVDAisle_1.Z28061.HeartbeatTimeoutAlarm",
+            SourceObjectReference = "Z28061.HeartbeatTimeoutAlarm",
+            AlarmTypeName = "Syst",
+            TransitionKind = ProtoTransitionKind.Raise,
+            Severity = 400
+        };
+
+        var snapT = MxGatewayAlarmMapper.MapSnapshot(snap);
+        var liveT = MxGatewayAlarmMapper.MapTransition(ev);
+
+        Assert.Equal("Z28061.HeartbeatTimeoutAlarm", snapT.SourceReference);
+        Assert.Equal("Z28061.HeartbeatTimeoutAlarm", liveT.SourceReference);
+        Assert.Equal("CVDAisle_1", snapT.Category);
+    }
+
+    [Fact]
+    public void SourceReference_FallsBackToFullReference_WhenObjectReferenceEmpty()
+    {
+        var snap = new ActiveAlarmSnapshot
+        {
+            AlarmFullReference = "Galaxy!Area.Obj.Alarm",
+            SourceObjectReference = "",
+            CurrentState = ProtoConditionState.Active,
+            Severity = 100
+        };
+
+        var t = MxGatewayAlarmMapper.MapSnapshot(snap);
+
+        Assert.Equal("Galaxy!Area.Obj.Alarm", t.SourceReference);
+    }
+
    // ── CurrentValue / LimitValue (M2.13 / #27) ──────────────────────────────

    [Fact]