fix(review): remediate re-review findings — DCL-029/InboundAPI-031/SiteRuntime-032/StoreAndForward-028 + Low doc/test

Fixes the 8 findings from the 2026-06-24 re-review (commit c42bb485), with a
regression test per Medium finding:

- DataConnectionLayer-029 (Med): HandleAlarmSubscribeCompleted now mirrors the
  tag-path re-check — if a feed is already stored for the source, release the
  redundant just-created subscription instead of overwriting + leaking the first
  one (the double-subscribe window DCL-023 reopened). +regression test.
- InboundAPI-031 (Med): remove WaitForAttribute's local 5s grace backstop (tighter
  than the CommunicationService Ask's timeout+IntegrationTimeout round-trip budget,
  so a slow-but-valid timed-out 'false' got cancelled into a 500). Link only the
  client-abort + explicit caller tokens; the lower layer owns the backstop. +test.
- SiteRuntime-032 (Med): derive the deployed count from an authoritative set of
  deployed config names (HashSet) instead of a map-presence-gated int, so deleting
  a DISABLED instance decrements correctly (SiteRuntime-029's gate leaked it).
  +deploy->disable->delete regression test.
- StoreAndForward-028 (Med): reset _bufferedCount in StopAsync alongside the
  register-guard so a same-instance Stop->Start re-seeds from a clean base (no ~2N
  gauge double-count). +restart regression test.
- AuditLog-017 (Low): test the OnIngestAsync scope-resolution guard (actor survives,
  replies empty, counts the failure) — no longer unpinned.
- CentralUI-037 / ScriptAnalysis-009 / SiteRuntime-033 (Low): doc-comment + spec
  fixes (Database-throws in the inbound sandbox; baseReferences param wording;
  native-alarm cap return-to-normal + per-condition NativeAlarmDropped eviction).

Targeted suites green: SiteRuntime 5, StoreAndForward 6, InboundAPI 31,
DataConnectionLayer 10, AuditLog 5, ScriptAnalysis 40, CentralUI ScriptAnalysis 52.

src/ZB.MOM.WW.ScadaBridge.InboundAPI/RouteHelper.cs

@@ -104,13 +104,6 @@ public class RouteHelper
 /// </summary>
 public class RouteTarget
 {
-    // InboundAPI-029: a small grace past the wait timeout. The SITE enforces the wait
-    // timeout and returns Matched=false when it elapses; the local backstop fires only
-    // if the site fails to respond, so it must sit slightly LATER than the wait timeout
-    // (it must not pre-empt the site's own timed-out response and turn a clean `false`
-    // into a cancellation).
-    private static readonly TimeSpan WaitResponseGrace = TimeSpan.FromSeconds(5);
-
     private readonly string _instanceCode;
     private readonly IInstanceLocator _instanceLocator;
     private readonly IInstanceRouter _instanceRouter;
@@ -261,11 +254,18 @@ public class RouteTarget
         TimeSpan timeout,
         CancellationToken cancellationToken = default)
     {
-        // InboundAPI-029: bound the wait by the WAIT timeout (+ grace backstop), the
-        // client-disconnect token, and an explicit caller token — NOT the method deadline.
-        using var waitCts = new CancellationTokenSource(timeout + WaitResponseGrace);
+        // InboundAPI-031: do NOT impose a local wait-timeout backstop here. The site
+        // enforces the wait `timeout` and returns Matched=false when it elapses, and the
+        // cluster Ask in CommunicationService.RouteToWaitForAttributeAsync already bounds
+        // the round trip by `timeout + IntegrationTimeout` — the authoritative backstop
+        // for a missing site response. A local CTS of `timeout + small grace` (the prior
+        // InboundAPI-029 approach) was TIGHTER than that round-trip budget, so a
+        // slow-but-valid timed-out response could be cancelled into an exception instead
+        // of the spec-mandated `false`. Link ONLY the client-disconnect token and an
+        // explicit caller token — NOT the method deadline — so a client abort still
+        // cancels the wait while the wait timeout itself governs the duration.
         using var linked = CancellationTokenSource.CreateLinkedTokenSource(
-            waitCts.Token, _requestAbortedToken, cancellationToken);
+            _requestAbortedToken, cancellationToken);
         var token = linked.Token;
         var siteId = await ResolveSiteAsync(token);