fix(deployment): drop dead ITemplateGraphWatermark ctor param and no-op ClearMemos from StaleInstanceProbe (review 2026-10-21 04/U2)

This commit is contained in:
Joseph Doherty
2026-10-22 06:35:02 -04:00
parent 7975699ac4
commit 971a9886b8
4 changed files with 24 additions and 36 deletions
@@ -1,21 +1,19 @@
using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Services;
using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Transport;
namespace ZB.MOM.WW.ScadaBridge.DeploymentManager;
/// <summary>Recomputes deployment revisions from authoritative configuration on every probe.
/// Process-local watermarks cannot prove freshness after another central changes the shared store.</summary>
/// Process-local watermarks cannot prove freshness after another central changes the shared store,
/// so nothing is memoised across calls.</summary>
public sealed class StaleInstanceProbe : IStaleInstanceProbe
{
private readonly IFlatteningPipeline _flatteningPipeline;
/// <summary>Initializes the authoritative probe. Watermark remains a constructor compatibility dependency.</summary>
/// <summary>Initializes the authoritative probe.</summary>
/// <param name="flatteningPipeline">The pipeline used to flatten instances for staleness comparison.</param>
/// <param name="watermark">The template graph watermark; retained only for constructor compatibility.</param>
public StaleInstanceProbe(IFlatteningPipeline flatteningPipeline, ITemplateGraphWatermark watermark)
public StaleInstanceProbe(IFlatteningPipeline flatteningPipeline)
{
_flatteningPipeline = flatteningPipeline ?? throw new ArgumentNullException(nameof(flatteningPipeline));
ArgumentNullException.ThrowIfNull(watermark);
}
/// <inheritdoc />
@@ -26,7 +24,4 @@ public sealed class StaleInstanceProbe : IStaleInstanceProbe
validateScripts: false, session).ConfigureAwait(false);
return result.IsSuccess ? result.Value.RevisionHash : null;
}
/// <summary>Compatibility hook: probes no longer retain process-global results.</summary>
public static void ClearMemos() { }
}