feat(reconcile): central handler — gap diff + fresh tokens + orphans

2026-06-26 16:20:17 -04:00
parent ec2aa2bbac
commit 96192950a0
5 changed files with 462 additions and 0 deletions
@@ -0,0 +1,79 @@
+using Akka.Actor;
+using Akka.TestKit.Xunit2;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging.Abstractions;
+using Microsoft.Extensions.Options;
+using NSubstitute;
+using ZB.MOM.WW.ScadaBridge.Commons.Entities.Deployment;
+using ZB.MOM.WW.ScadaBridge.Commons.Entities.Sites;
+using ZB.MOM.WW.ScadaBridge.Commons.Interfaces.Repositories;
+using ZB.MOM.WW.ScadaBridge.Commons.Messages.Deployment;
+using ZB.MOM.WW.ScadaBridge.Commons.Types.Deployment;
+using ZB.MOM.WW.ScadaBridge.Communication.Actors;
+
+namespace ZB.MOM.WW.ScadaBridge.Communication.Tests;
+
+/// <summary>
+/// Tests that <see cref="CentralCommunicationActor"/> routes a site→central
+/// <see cref="ReconcileSiteRequest"/> through the scoped <see cref="ReconcileService"/>
+/// and pipes the resulting <see cref="ReconcileSiteResponse"/> back to the original
+/// sender (the site's ClusterClient path). Mirrors the audit-ingest routing tests.
+/// </summary>
+public class CentralCommunicationActorReconcileTests : TestKit
+{
+    [Fact]
+    public void ReconcileSiteRequest_RoutesResponseToSender()
+    {
+        var deploymentRepo = Substitute.For<IDeploymentManagerRepository>();
+        var siteRepo = Substitute.For<ISiteRepository>();
+
+        // GetAllSitesAsync is called by the actor's periodic refresh; keep it empty.
+        siteRepo.GetAllSitesAsync(Arg.Any<CancellationToken>())
+            .Returns(new List<Site>());
+
+        siteRepo.GetSiteByIdentifierAsync("site1", Arg.Any<CancellationToken>())
+            .Returns(new Site("Site One", "site1") { Id = 7 });
+
+        deploymentRepo.GetExpectedDeploymentsForSiteAsync(7, Arg.Any<CancellationToken>())
+            .Returns(new List<ExpectedDeployment>
+            {
+                new(2, "inst-B", "rev2", "dep-B", true),
+            });
+        deploymentRepo.GetDeployedSnapshotByInstanceIdAsync(2, Arg.Any<CancellationToken>())
+            .Returns(new DeployedConfigSnapshot("dep-B", "rev2", "{\"cfg\":\"B\"}"));
+        deploymentRepo.StagePendingIfAbsentAsync(
+                Arg.Any<int>(), Arg.Any<string>(), Arg.Any<string>(), Arg.Any<string>(),
+                Arg.Any<string>(), Arg.Any<DateTimeOffset>(), Arg.Any<DateTimeOffset>(),
+                Arg.Any<CancellationToken>())
+            .Returns(true);
+
+        var options = Options.Create(new CommunicationOptions
+        {
+            CentralFetchBaseUrl = "https://central.example:9000",
+            PendingDeploymentTtl = TimeSpan.FromMinutes(5),
+        });
+
+        var services = new ServiceCollection();
+        services.AddScoped(_ => deploymentRepo);
+        services.AddScoped(_ => siteRepo);
+        services.AddSingleton(options);
+        services.AddSingleton<Microsoft.Extensions.Logging.ILogger<ReconcileService>>(
+            NullLogger<ReconcileService>.Instance);
+        services.AddScoped<ReconcileService>();
+        var sp = services.BuildServiceProvider();
+
+        var factory = Substitute.For<ISiteClientFactory>();
+        var actor = Sys.ActorOf(Props.Create(() => new CentralCommunicationActor(sp, factory, null)));
+
+        // Node B is missing inst-B entirely → it should come back as a gap item.
+        actor.Tell(new ReconcileSiteRequest(
+            "site1", "node-b",
+            new Dictionary<string, string>()));
+
+        var response = ExpectMsg<ReconcileSiteResponse>(TimeSpan.FromSeconds(5));
+        var gap = Assert.Single(response.Gap);
+        Assert.Equal("inst-B", gap.InstanceUniqueName);
+        Assert.Equal("dep-B", gap.DeploymentId);
+        Assert.False(string.IsNullOrWhiteSpace(gap.FetchToken));
+    }
+}