fix(cluster): leader-auto-down restarts a node its peer has shut out; higher address restarts when both are (#132)

A node frozen past failure detection + StableAfter, or both sides of a partition
that heals after each downed the other, used to stay a second active node until an
operator restarted one: the peer quarantines the removed UID and Akka.Cluster
1.5.62 never acts on ThisActorSystemQuarantinedEvent.

ShutOutRestart (child of the LeaderAutoDown downing actor; opt-out via
ScadaBridge:Cluster:LeaderAutoDown:RestartWhenShutOut, default on for
leader-auto-down only) watches two signals:
- S1 ThisActorSystemQuarantinedEvent: the peer quarantined this node. If the peer
  is still a live member here, only this side can be shut out -> restart now.
- S2 AssociationErrorEvent 'has a UID that has been quarantined': the peer still
  runs the incarnation this node removed. A healed partition yields only S2, on
  both sides. Wait ShutOutGrace (60s) for a frozen peer to restart itself, then
  tiebreak.
Tiebreak: the higher address (Akka Member.AddressOrdering) restarts, the lower
stays and restarts only if still split one grace later. Removed peers are probed
(Identify, 5s -> 60s back-off) since nothing else contacts them after mutual
removal. Restart = Cluster.Down(self) -> existing self-down path.

The Host now exits 75 after an unplanned ActorSystem termination (and sets it on
the Windows service before it reports stopped): SCM recovery with failureflag 1
only restarts a service that stops with a non-zero code, and the watchdog used
to exit 0. Shipped default strategy stays auto-down.

Claude-Session: https://claude.ai/code/session_01GT67ACmpMR7b9LGRPLijMi
This commit is contained in:
Joseph Doherty
2026-11-12 20:57:42 -05:00
parent a633005f4f
commit 952db02aab
14 changed files with 1646 additions and 10 deletions
@@ -69,6 +69,8 @@ public sealed class UnexpectedTerminationTests
await Task.Delay(500);
lifetime.Received(1).StopApplication();
// ScadaBridge#132: Program turns this flag into the non-zero SelfDownExitCode.
Assert.True(service.TerminatedOutsideHostShutdown);
}
/// <summary>Verifies that a normal stop does not trigger an application stop.</summary>
@@ -84,5 +86,19 @@ public sealed class UnexpectedTerminationTests
await Task.Delay(500);
lifetime.DidNotReceive().StopApplication();
Assert.False(service.TerminatedOutsideHostShutdown);
}
/// <summary>
/// ScadaBridge#132: the self-down exit code is non-zero (Windows service recovery with
/// failureflag 1 restarts only on a non-zero exit) and is only pushed into a Windows service
/// lifetime — a console / docker lifetime is left alone.
/// </summary>
[Fact]
public void SelfDownExitCode_IsNonZero_AndOnlyAppliedToAServiceLifetime()
{
Assert.NotEqual(0, AkkaHostedService.SelfDownExitCode);
Assert.False(AkkaHostedService.MarkServiceSelfDownExit(null));
Assert.False(AkkaHostedService.MarkServiceSelfDownExit(Substitute.For<IHostLifetime>()));
}
}