fix(notification-outbox): per-attempt timestamps, Pending/Retrying split claim + sweep budget, SMTP MaxConcurrentConnections clamp (review 2026-10-21 06/COR-1, 06/PERF-5, 06/IMPL-2)

2026-10-22 09:22:10 -04:00
parent ebf4b96789
commit 811a561885
10 changed files with 547 additions and 37 deletions
@@ -32,7 +32,10 @@ public interface INotificationOutboxRepository
    /// Returns notifications ready for a delivery attempt: <c>Pending</c> rows, plus
    /// <c>Retrying</c> rows whose <c>NextAttemptAt</c> is at or before <paramref name="now"/>.
    /// Terminal rows are excluded. Ordered by <c>CreatedAt</c> ascending, capped at
-    /// <paramref name="batchSize"/>.
+    /// <paramref name="batchSize"/>. The batch is shared between the two statuses — due
+    /// <c>Retrying</c> rows take at most half, <c>Pending</c> rows the rest, and a share
+    /// the other status cannot fill is back-filled — so a retrying backlog can never starve
+    /// fresh traffic (review 2026-10-21 06/PERF-5).
    /// </summary>
    /// <param name="now">The current time for evaluating due retries.</param>
    /// <param name="batchSize">Maximum number of rows to return.</param>