dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

chore(hygiene): fix stale area-export comment in EntitySerializer.FromBundleContent — areas travel by name since PLAN-05 (plan R2-08 T12, arch-review 08r2 NF6)

Browse Source
This commit is contained in:
Joseph Doherty
2026-07-13 10:58:52 -04:00
parent 7943d73e71
commit 80b967681e
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ZB.MOM.WW.ScadaBridge.Transport/Serialization/EntitySerializer.cs
+8 -2
View File
@@ -550,8 +550,14 @@ public sealed class EntitySerializer
}) })
.ToList(); .ToList();
// Instances: resolve template + site by name/identifier. Areas don't travel // Instances: resolve template + site by name/identifier. Areas DO travel —
// (see export TODO), so AreaId stays null. Connection bindings keep their // by NAME on InstanceDto.AreaName (export resolves AreaId→AreaNameById; the
// importer resolves-or-creates the area under the target site). This helper
// still materializes AreaId = null for the same reason the connection-binding
// FK below is a placeholder: FromBundleContent is NOT on the importer's path
// (BundleImporter walks the raw DTO) and has no target-DB name→id map to
// resolve against. Round-trip fidelity for the area lives on the DTO, not on
// this materialized entity. Connection bindings keep their
// resolved DataConnection NAME on the wire DTO — the importer reads // resolved DataConnection NAME on the wire DTO — the importer reads
// bindings from BundleContentDto.Instances[].ConnectionBindings directly and // bindings from BundleContentDto.Instances[].ConnectionBindings directly and
// resolves ConnectionName→the target environment's DataConnectionId at apply // resolves ConnectionName→the target environment's DataConnectionId at apply