feat(dcl): bound per-tag seed ReadAsync with SeedReadTimeout (#232, DCL-027)
This commit is contained in:
@@ -780,9 +780,16 @@ public class DataConnectionActor : UntypedActor, IWithStash, IWithTimers
|
||||
{
|
||||
foreach (var tagPath in pending.ToList())
|
||||
{
|
||||
// DataConnectionLayer-027: bound each per-tag read with SeedReadTimeout so a
|
||||
// hung device read cannot delay SubscribeCompleted/the ack indefinitely.
|
||||
// On timeout the catch block treats it identically to any other failed seed
|
||||
// read — the tag stays in pending, is retried up to SeedReadMaxAttempts, and
|
||||
// left Uncertain if still empty after the budget. Same CancellationTokenSource
|
||||
// mechanism used by HandleWrite for WriteTimeout (DataConnectionLayer-005).
|
||||
using var cts = new CancellationTokenSource(_options.SeedReadTimeout);
|
||||
try
|
||||
{
|
||||
var readResult = await adapter.ReadAsync(tagPath);
|
||||
var readResult = await adapter.ReadAsync(tagPath, cts.Token);
|
||||
if (readResult.Success && readResult.Value is { Value: not null } value)
|
||||
{
|
||||
seedValues.Add(new SeededValue(tagPath, value));
|
||||
@@ -792,6 +799,7 @@ public class DataConnectionActor : UntypedActor, IWithStash, IWithTimers
|
||||
catch
|
||||
{
|
||||
// Best-effort read — retried below, or logged once the budget is spent.
|
||||
// Includes OperationCanceledException on SeedReadTimeout expiry.
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -14,6 +14,16 @@ public class DataConnectionOptions
|
||||
/// <summary>Timeout for synchronous write operations to devices.</summary>
|
||||
public TimeSpan WriteTimeout { get; set; } = TimeSpan.FromSeconds(30);
|
||||
|
||||
/// <summary>
|
||||
/// DataConnectionLayer-027: per-tag timeout applied to each <see cref="IDataConnection.ReadAsync"/>
|
||||
/// call on the initial-subscribe seed path (and reconnect re-seed). A hung device read would
|
||||
/// otherwise delay <c>SubscribeCompleted</c> and its acknowledgement indefinitely. On timeout
|
||||
/// the tag is treated the same as any other failed seed read — it stays in the pending set and
|
||||
/// is retried up to <see cref="SeedReadMaxAttempts"/>, then left Uncertain until a change
|
||||
/// notification arrives.
|
||||
/// </summary>
|
||||
public TimeSpan SeedReadTimeout { get; set; } = TimeSpan.FromSeconds(30);
|
||||
|
||||
/// <summary>
|
||||
/// Minimum time a connection must stay up before it is considered stable.
|
||||
/// If a connection drops before this threshold, it counts as an unstable
|
||||
|
||||
Reference in New Issue
Block a user