From 7bd081ba5034aabd0f72796994655ce96b6f758b Mon Sep 17 00:00:00 2001
From: Joseph Doherty <dohejw01@gmail.com>
Date: Fri, 19 Jun 2026 04:16:01 -0400
Subject: [PATCH] fix(ui): move Razor comment outside <select> start tag in
 Health.razor (circuit crash, #291)

Pre-existing render-crash (introduced by eb4bce3e): a @* *@ comment between
attributes inside the site-health-trends <select> start tag rendered as an
invalid attribute name in a real browser (InvalidCharacterError on setAttribute),
tearing down the SignalR circuit whenever Site Health Trends renders. bUnit's
virtual DOM masked it; the live Playwright smoke (KpiTiles) caught it. Comment
moved outside the start tag.
---
 .../Components/Pages/Monitoring/Health.razor                    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Monitoring/Health.razor b/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Monitoring/Health.razor
index b71bfda1..f237283f 100644
--- a/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Monitoring/Health.razor
+++ b/src/ZB.MOM.WW.ScadaBridge.CentralUI/Components/Pages/Monitoring/Health.razor
@@ -89,10 +89,10 @@
                 <h6 class="text-muted mb-0 me-3">Site Health Trends</h6>
                 @if (_trendSiteKeys.Count > 0)
                 {
+                    @* OnTrendSiteChangedAsync is async — Blazor wraps it in an EventCallback so the returned Task IS awaited; keep the Async signature, do not change it to a void/fire-and-forget handler. This comment MUST stay OUTSIDE the <select> start tag: a Razor comment placed between attributes renders as an invalid attribute name and crashes the SignalR circuit (InvalidCharacterError on setAttribute). *@
                     <select class="form-select form-select-sm" style="width:auto"
                             data-test="site-health-trends-site"
                             value="@_trendSiteId"
-                            @* Blazor wraps this async handler in an EventCallback, so the returned Task IS awaited — keep the Async signature; do not change it to a void/fire-and-forget handler. *@
                             @onchange="OnTrendSiteChangedAsync">
                         @foreach (var key in _trendSiteKeys)
                         {