fix(options): canonicalize Communication/DataConnection config sections to ScadaBridge:*; drop the duplicate Host bindings that were masking the drift (plan R2-08 T9, arch-review 08r2 NF8)

src/ZB.MOM.WW.ScadaBridge.DataConnectionLayer/DataConnectionOptionsValidator.cs

@@ -4,7 +4,7 @@ namespace ZB.MOM.WW.ScadaBridge.DataConnectionLayer;
 
 /// <summary>
 /// Validates <see cref="DataConnectionOptions"/> at startup (ValidateOnStart) so a
-/// malformed "DataConnectionLayer" appsettings section fails fast at boot with a
+/// malformed "ScadaBridge:DataConnection" appsettings section fails fast at boot with a
 /// key-naming message instead of surfacing later at runtime. The intervals drive
 /// the reconnect/tag-resolution timers and the seed-read retry loop; a
 /// zero/negative duration (or a non-positive <c>SeedReadMaxAttempts</c>) would
@@ -16,24 +16,24 @@ public sealed class DataConnectionOptionsValidator : OptionsValidatorBase<DataCo
     protected override void Validate(ValidationBuilder builder, DataConnectionOptions options)
     {
         builder.RequireThat(options.ReconnectInterval > TimeSpan.Zero,
-            $"DataConnectionLayer:ReconnectInterval must be a positive duration (was {options.ReconnectInterval}).");
+            $"ScadaBridge:DataConnection:ReconnectInterval must be a positive duration (was {options.ReconnectInterval}).");
 
         builder.RequireThat(options.TagResolutionRetryInterval > TimeSpan.Zero,
-            $"DataConnectionLayer:TagResolutionRetryInterval must be a positive duration (was {options.TagResolutionRetryInterval}).");
+            $"ScadaBridge:DataConnection:TagResolutionRetryInterval must be a positive duration (was {options.TagResolutionRetryInterval}).");
 
         builder.RequireThat(options.WriteTimeout > TimeSpan.Zero,
-            $"DataConnectionLayer:WriteTimeout must be a positive duration (was {options.WriteTimeout}).");
+            $"ScadaBridge:DataConnection:WriteTimeout must be a positive duration (was {options.WriteTimeout}).");
 
         builder.RequireThat(options.SeedReadTimeout > TimeSpan.Zero,
-            $"DataConnectionLayer:SeedReadTimeout must be a positive duration (was {options.SeedReadTimeout}).");
+            $"ScadaBridge:DataConnection:SeedReadTimeout must be a positive duration (was {options.SeedReadTimeout}).");
 
         builder.RequireThat(options.StableConnectionThreshold > TimeSpan.Zero,
-            $"DataConnectionLayer:StableConnectionThreshold must be a positive duration (was {options.StableConnectionThreshold}).");
+            $"ScadaBridge:DataConnection:StableConnectionThreshold must be a positive duration (was {options.StableConnectionThreshold}).");
 
         builder.RequireThat(options.SeedReadRetryDelay > TimeSpan.Zero,
-            $"DataConnectionLayer:SeedReadRetryDelay must be a positive duration (was {options.SeedReadRetryDelay}).");
+            $"ScadaBridge:DataConnection:SeedReadRetryDelay must be a positive duration (was {options.SeedReadRetryDelay}).");
 
         builder.RequireThat(options.SeedReadMaxAttempts > 0,
-            $"DataConnectionLayer:SeedReadMaxAttempts must be positive (was {options.SeedReadMaxAttempts}).");
+            $"ScadaBridge:DataConnection:SeedReadMaxAttempts must be positive (was {options.SeedReadMaxAttempts}).");
     }
 }

src/ZB.MOM.WW.ScadaBridge.DataConnectionLayer/MxGatewayGlobalOptions.cs

@@ -1,8 +1,8 @@
 namespace ZB.MOM.WW.ScadaBridge.DataConnectionLayer;
 
 /// <summary>
-/// Deployment-wide MxGateway defaults, bound from the "MxGateway" section of
-/// appsettings.json. Per-endpoint behavior lives on MxGatewayEndpointConfig.
+/// Deployment-wide MxGateway defaults, bound from the "ScadaBridge:MxGateway" section
+/// of appsettings.json. Per-endpoint behavior lives on MxGatewayEndpointConfig.
 /// </summary>
 public class MxGatewayGlobalOptions
 {

src/ZB.MOM.WW.ScadaBridge.DataConnectionLayer/OpcUaGlobalOptions.cs

@@ -1,8 +1,8 @@
 namespace ZB.MOM.WW.ScadaBridge.DataConnectionLayer;
 
 /// <summary>
-/// Deployment-wide OPC UA application identity. Bound from the "OpcUa" section
-/// of appsettings.json. Per-endpoint behavior lives on OpcUaEndpointConfig.
+/// Deployment-wide OPC UA application identity. Bound from the "ScadaBridge:OpcUa"
+/// section of appsettings.json. Per-endpoint behavior lives on OpcUaEndpointConfig.
 /// Empty paths fall back to a default under Path.GetTempPath() so dev runs
 /// work without explicit configuration.
 /// </summary>

src/ZB.MOM.WW.ScadaBridge.DataConnectionLayer/ServiceCollectionExtensions.cs

@@ -14,20 +14,26 @@ public static class ServiceCollectionExtensions
     /// <returns>The same <paramref name="services"/> instance for chaining.</returns>
     public static IServiceCollection AddDataConnectionLayer(this IServiceCollection services)
     {
+        // Canonical section is ScadaBridge:DataConnection — the section every real
+        // appsettings actually writes (arch-review 08 round 2 NF8). The Host used to
+        // supply the real values via a duplicate Configure<> binding; that duplicate is
+        // gone, so AddDataConnectionLayer must bind the canonical section itself.
         services.AddOptions<DataConnectionOptions>()
-            .BindConfiguration("DataConnectionLayer")
+            .BindConfiguration("ScadaBridge:DataConnection")
             .ValidateOnStart();
         services.TryAddEnumerable(
             ServiceDescriptor.Singleton<IValidateOptions<DataConnectionOptions>, DataConnectionOptionsValidator>());
 
         // OpcUaGlobalOptions / MxGatewayGlobalOptions carry only string identity/path
         // fields (no numeric or duration knobs), so there is nothing to range-validate
-        // — no dedicated validator is registered for them.
+        // — no dedicated validator is registered for them. Canonical sections are
+        // ScadaBridge:OpcUa / ScadaBridge:MxGateway (NF8): the bare "OpcUa"/"MxGateway"
+        // sections exist in no appsettings, so binding them read nothing.
         services.AddOptions<OpcUaGlobalOptions>()
-            .BindConfiguration("OpcUa");
+            .BindConfiguration("ScadaBridge:OpcUa");
 
         services.AddOptions<MxGatewayGlobalOptions>()
-            .BindConfiguration("MxGateway");
+            .BindConfiguration("ScadaBridge:MxGateway");
 
         // Register the factory for protocol extensibility
         services.AddSingleton<IDataConnectionFactory, DataConnectionFactory>();