feat(centralui): grouped Connection Bindings panel — rows sourced from the flattened config (composed module members were invisible; flatten failure falls back to direct attributes with a banner), per-module connection + Object apply, unbound/mixed pills, show-only-unbound filter, Test Bindings covers composed rows, per-row Browse retained

2026-08-20 15:59:51 -04:00
parent 02a374259b
commit 77f4af0d64
5 changed files with 466 additions and 106 deletions
@@ -0,0 +1,49 @@
+namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Deployment;
+
+/// <summary>
+/// Design 2026-08-20: the Connection Bindings panel must be driven by the flattened
+/// configuration (every composed module member), not by the template's direct
+/// attributes — 264 of Z28061's 280 bindings were invisible on QA. Structural pins
+/// over the page source, matching the existing InstanceConfigure coverage style.
+/// </summary>
+public class InstanceConfigureBindingRowsTests
+{
+    internal static string ReadMarkup()
+    {
+        var dir = AppContext.BaseDirectory;
+        for (var i = 0; i < 6 && dir is not null; i++) dir = Directory.GetParent(dir)?.FullName;
+        return File.ReadAllText(Path.Combine(dir!, "src", "ZB.MOM.WW.ScadaBridge.CentralUI",
+            "Components", "Pages", "Deployment", "InstanceConfigure.razor"));
+    }
+
+    private static string Markup => ReadMarkup();
+
+    [Fact]
+    public void BindingRows_ComeFromFlattenedConfiguration_NotTemplateAttributes()
+    {
+        var m = Markup;
+        Assert.Contains("LoadBindingRowsAsync", m);
+        Assert.Contains("BindingGroupBuilder.Build(", m);
+        // The old direct-attribute projection must be gone from the bindings path.
+        Assert.DoesNotContain("_bindingDataSourceAttrs = attrs.Where(a => !string.IsNullOrEmpty(a.DataSourceReference))", m);
+        Assert.Contains("DefaultDataSourceReference", m);
+    }
+
+    [Fact]
+    public void BindingRows_FallBackToDirectAttributes_WithBanner_WhenFlattenFails()
+    {
+        var m = Markup;
+        Assert.Contains("_bindingSourceWarning", m);
+        Assert.Contains("data-test=\"binding-source-warning\"", m);
+    }
+
+    [Fact]
+    public void SaveAndTest_CoverEveryRow()
+    {
+        var m = Markup.Replace("\r\n", "\n");
+        // Save posts the whole selection dictionary (hidden-row survival property).
+        Assert.Contains("_bindingSelections\n                .Select(kv => new ConnectionBinding(", m);
+        // Test Bindings iterates the grouped rows, not the legacy attr list.
+        Assert.Contains("foreach (var g in _bindingGroups)", m);
+    }
+}