From 68f911e634570d84e7e5f87883dff03b59ea5de6 Mon Sep 17 00:00:00 2001 From: Joseph Doherty Date: Sun, 7 Jun 2026 10:31:02 -0400 Subject: [PATCH] docs: note alarmOverrides in GetInstanceDocumentAsync; mark template-alarm/override plan complete --- ...arm-cli-and-override-coverage.md.tasks.json | 18 +++++++++--------- .../Cluster/CliRunner.Helpers.cs | 3 ++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/docs/plans/2026-06-07-template-alarm-cli-and-override-coverage.md.tasks.json b/docs/plans/2026-06-07-template-alarm-cli-and-override-coverage.md.tasks.json index e025a789..9f8542ac 100644 --- a/docs/plans/2026-06-07-template-alarm-cli-and-override-coverage.md.tasks.json +++ b/docs/plans/2026-06-07-template-alarm-cli-and-override-coverage.md.tasks.json @@ -2,15 +2,15 @@ "planPath": "docs/plans/2026-06-07-template-alarm-cli-and-override-coverage.md", "lastUpdated": "2026-06-07T00:00:00Z", "nativeTaskIdBase": 125, - "status": "pending", + "status": "completed", "tasks": [ - {"id": 0, "nativeId": 125, "subject": "Task 0: CLI AlarmTriggerConfigJson + typed flags on template alarm add", "status": "pending"}, - {"id": 1, "nativeId": 126, "subject": "Task 1: CliRunner.AddAlarmAsync + DeleteInstanceAlarmOverrideAsync + round-trip test", "status": "pending", "blockedBy": [0]}, - {"id": 2, "nativeId": 127, "subject": "Task 2: data-test hooks on InstanceConfigure alarm section + docker rebuild", "status": "pending", "blockedBy": [1]}, - {"id": 3, "nativeId": 128, "subject": "Task 3: fixture alarm in InstanceConfigureFixture", "status": "pending", "blockedBy": [1, 2]}, - {"id": 4, "nativeId": 129, "subject": "Task 4: AlarmOverride_SetPriority_ThenClear_RoundTrips test", "status": "pending", "blockedBy": [2, 3]}, - {"id": 5, "nativeId": 130, "subject": "Task 5: SiteCalls hygiene (plant-a surgical + pager scope + next re-assert)", "status": "pending"}, - {"id": 6, "nativeId": 131, "subject": "Task 6: Notification hygiene + DeleteRoleMappingAsync doc note", "status": "pending"}, - {"id": 7, "nativeId": 132, "subject": "Task 7: Verification + residue check", "status": "pending", "blockedBy": [0, 1, 2, 3, 4, 5, 6]} + {"id": 0, "nativeId": 125, "subject": "Task 0: CLI AlarmTriggerConfigJson + typed flags on template alarm add", "status": "completed"}, + {"id": 1, "nativeId": 126, "subject": "Task 1: CliRunner.AddAlarmAsync + DeleteInstanceAlarmOverrideAsync + round-trip test", "status": "completed", "blockedBy": [0]}, + {"id": 2, "nativeId": 127, "subject": "Task 2: data-test hooks on InstanceConfigure alarm section + docker rebuild", "status": "completed", "blockedBy": [1]}, + {"id": 3, "nativeId": 128, "subject": "Task 3: fixture alarm in InstanceConfigureFixture", "status": "completed", "blockedBy": [1, 2]}, + {"id": 4, "nativeId": 129, "subject": "Task 4: AlarmOverride_SetPriority_ThenClear_RoundTrips test", "status": "completed", "blockedBy": [2, 3]}, + {"id": 5, "nativeId": 130, "subject": "Task 5: SiteCalls hygiene (plant-a surgical + pager scope + next re-assert)", "status": "completed"}, + {"id": 6, "nativeId": 131, "subject": "Task 6: Notification hygiene + DeleteRoleMappingAsync doc note", "status": "completed"}, + {"id": 7, "nativeId": 132, "subject": "Task 7: Verification + residue check", "status": "completed", "blockedBy": [0, 1, 2, 3, 4, 5, 6]} ] } diff --git a/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Cluster/CliRunner.Helpers.cs b/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Cluster/CliRunner.Helpers.cs index fa00fd2f..bc9c2013 100644 --- a/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Cluster/CliRunner.Helpers.cs +++ b/tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Cluster/CliRunner.Helpers.cs @@ -426,7 +426,8 @@ public static partial class CliRunner /// /// Reads an instance's full configuration via instance get; the returned document exposes - /// connectionBindings, attributeOverrides, and areaId for persistence read-back. + /// connectionBindings, attributeOverrides, alarmOverrides, and areaId + /// for persistence read-back. /// /// /// This is the only helper that hands back a live (the rest return