refactor(comm): retire ClusterClient naming after the gRPC cutover

Phase 4 of the ClusterClient -> gRPC migration deleted the Akka transports but left the naming behind: `ClusterClientSiteAuditClient` was transport- agnostic and worked unchanged, so it survived the deletion under a name that now describes a transport the repo no longer has. Same for a scatter of doc-comments still framing gRPC as "the new transport" beside an Akka one that is gone. Renames it to `SiteCommunicationAuditClient` (and its test file) and rewrites the stale comments to describe the single transport that exists. Also tightens CLAUDE.md: drops the self-describing directory listing and the 27-component enumeration in favour of the non-obvious parts only. Behaviour-neutral: names and prose only. Recorded as the Phase 4 follow-up in docs/plans/2026-07-22-clusterclient-to-grpc-plan.md.
2026-07-27 15:40:01 -04:00
parent b3dc17a5fe
commit 63c16d6912
57 changed files with 193 additions and 244 deletions
@@ -104,7 +104,7 @@ public class SiteCommunicationActorTransportTests : TestKit
        // The seam preserves the reply-routing the S&F layer depends on: when the transport
        // answers the captured replyTo with a Status.Failure (its transient-failure signal on a
        // non-OK status), that failure reaches the original sender — here the test actor — so the
-        // waiting Ask faults, exactly as it did on the ClusterClient path.
+        // waiting Ask faults, exactly as it did on the removed ClusterClient path.
        var transport = Substitute.For<ICentralTransport>();
        transport
            .When(t => t.SubmitNotification(Arg.Any<NotificationSubmit>(), Arg.Any<IActorRef>()))
@@ -15,10 +15,10 @@ using ZB.MOM.WW.ScadaBridge.Communication.Actors;
 namespace ZB.MOM.WW.ScadaBridge.Communication.Tests;

 /// <summary>
-/// Tests for the Audit Log (#23) site→central ClusterClient ingest routing on
-/// <see cref="CentralCommunicationActor"/>. A site ClusterClient delivers
+/// Tests for the Audit Log (#23) site→central ingest routing on
+/// <see cref="CentralCommunicationActor"/>. A site delivers
 /// <see cref="IngestAuditEventsCommand"/> / <see cref="IngestCachedTelemetryCommand"/>
-/// to the receptionist-registered actor, which forwards to the registered
+/// to the actor, which forwards to the registered
 /// <c>AuditLogIngestActor</c> proxy and routes the reply back to the site.
 /// Mirrors the NotificationSubmit / RegisterNotificationOutbox pattern.
 /// </summary>
@@ -17,7 +17,7 @@ namespace ZB.MOM.WW.ScadaBridge.Communication.Tests;
 /// Tests that <see cref="CentralCommunicationActor"/> routes a site→central
 /// <see cref="ReconcileSiteRequest"/> through the scoped <see cref="ReconcileService"/>
 /// and pipes the resulting <see cref="ReconcileSiteResponse"/> back to the original
-/// sender (the site's ClusterClient path). Mirrors the audit-ingest routing tests.
+/// sender (the site's transport path). Mirrors the audit-ingest routing tests.
 /// </summary>
 public class CentralCommunicationActorReconcileTests : TestKit
 {
@@ -293,7 +293,7 @@ public class DebugStreamBridgeActorTests : TestKit

        ctx.BridgeActor.Tell(new StopDebugStream());

-        // Should send ClusterClient unsubscribe
+        // Should send the site-addressed unsubscribe
        var envelope = ctx.CommProbe.ExpectMsg<SiteEnvelope>();
        Assert.IsType<UnsubscribeDebugViewRequest>(envelope.Message);

@@ -60,7 +60,7 @@ public class SiteCommunicationActorTests : TestKit
    public void DeploymentStateQuery_ForwardedToDeploymentManager()
    {
        // DeploymentManager-006: the site-before-redeploy query travels over the
-        // ClusterClient command/control transport and is routed to the local
+        // gRPC command/control transport and is routed to the local
        // Deployment Manager, which owns the deployed-config store.
        var dmProbe = CreateTestProbe();
        var siteActor = Sys.ActorOf(Props.Create(() =>