dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(transport): carry script cadence/timeout fields through bundle import (was silently reset to defaults)

Browse Source 
Claude-Session: https://claude.ai/code/session_01MtdgwpEeCUn6cUA5f1LMPj
This commit is contained in:
Joseph Doherty
2026-07-09 16:09:50 -04:00
parent 4d4ae05fc2
commit 5c52b4c80b
2 changed files with 209 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ZB.MOM.WW.ScadaBridge.Transport/Import/BundleImporter.cs
+9 -1
View File
@@ -1571,6 +1571,8 @@ public sealed class BundleImporter : IBundleImporter
ParameterDefinitions = s.ParameterDefinitions,
ReturnDefinition = s.ReturnDefinition,
IsLocked = s.IsLocked,
MinTimeBetweenRuns = s.MinTimeBetweenRuns,
ExecutionTimeoutSeconds = s.ExecutionTimeoutSeconds,
});
}
return t;
@@ -1854,7 +1856,9 @@ public sealed class BundleImporter : IBundleImporter
!string.Equals(current.TriggerConfiguration, scriptDto.TriggerConfiguration, StringComparison.Ordinal) ||
!string.Equals(current.ParameterDefinitions, scriptDto.ParameterDefinitions, StringComparison.Ordinal) ||
!string.Equals(current.ReturnDefinition, scriptDto.ReturnDefinition, StringComparison.Ordinal) ||
current.IsLocked != scriptDto.IsLocked;
current.IsLocked != scriptDto.IsLocked ||
current.MinTimeBetweenRuns != scriptDto.MinTimeBetweenRuns ||
current.ExecutionTimeoutSeconds != scriptDto.ExecutionTimeoutSeconds;
if (!changed) continue;
current.Code = scriptDto.Code;
@@ -1863,6 +1867,8 @@ public sealed class BundleImporter : IBundleImporter
current.ParameterDefinitions = scriptDto.ParameterDefinitions;
current.ReturnDefinition = scriptDto.ReturnDefinition;
current.IsLocked = scriptDto.IsLocked;
current.MinTimeBetweenRuns = scriptDto.MinTimeBetweenRuns;
current.ExecutionTimeoutSeconds = scriptDto.ExecutionTimeoutSeconds;
await _templateRepo.UpdateTemplateScriptAsync(current, ct).ConfigureAwait(false);
await _auditService.LogAsync(
user,
@@ -1889,6 +1895,8 @@ public sealed class BundleImporter : IBundleImporter
ParameterDefinitions = scriptDto.ParameterDefinitions,
ReturnDefinition = scriptDto.ReturnDefinition,
IsLocked = scriptDto.IsLocked,
MinTimeBetweenRuns = scriptDto.MinTimeBetweenRuns,
ExecutionTimeoutSeconds = scriptDto.ExecutionTimeoutSeconds,
};
ex.Scripts.Add(newScript);
await _auditService.LogAsync(