fix(auth): refuse zero-role sign-in at /auth/login and /auth/token (#144)
A successful LDAP bind whose groups map to no ScadaBridge role, or whose role mapping throws, is now refused at both sign-in endpoints exactly like a bad password: the same redirect/401 body, no cookie, no token, and a login-throttle failure (so the throttle is not an oracle). The reason is logged server-side at Warning with the endpoint and username. Family standard: scadaproj NAM AD cutover plan §3.2 (Phase A2, §2A). Tests: zero roles, mapper throws, and one role for both endpoints, plus the throttle accounting; RoutePolicyCoverageTests now notes that the two bare [Authorize] pages rely on this rule. Claude-Session: https://claude.ai/code/session_01GT67AFKC45MBz1wPZnVbX8
This commit is contained in:
@@ -12,6 +12,10 @@ public class RoutePolicyCoverageTests
|
||||
[Fact]
|
||||
public void EveryRoutableComponent_HasItsReviewedPolicy_IncludingExternalSecrets()
|
||||
{
|
||||
// "authenticated" (bare [Authorize]) is safe only because sign-in requires a mapped role:
|
||||
// /auth/login and /auth/token refuse a zero-role bind, and a session whose roles drop to zero
|
||||
// is ended by CookieSessionValidator (ScadaBridge#144, "no role, no login"). Do not add an
|
||||
// "authenticated" page that would be unsafe for a holder of any single role.
|
||||
var expected = new Dictionary<string, string>
|
||||
{
|
||||
["/"] = "authenticated",
|
||||
|
||||
Reference in New Issue
Block a user