fix(auth): refuse zero-role sign-in at /auth/login and /auth/token (#144)

A successful LDAP bind whose groups map to no ScadaBridge role, or whose role
mapping throws, is now refused at both sign-in endpoints exactly like a bad
password: the same redirect/401 body, no cookie, no token, and a login-throttle
failure (so the throttle is not an oracle). The reason is logged server-side at
Warning with the endpoint and username. Family standard: scadaproj NAM AD
cutover plan §3.2 (Phase A2, §2A).

Tests: zero roles, mapper throws, and one role for both endpoints, plus the
throttle accounting; RoutePolicyCoverageTests now notes that the two bare
[Authorize] pages rely on this rule.

Claude-Session: https://claude.ai/code/session_01GT67AFKC45MBz1wPZnVbX8
This commit is contained in:
Joseph Doherty
2026-11-17 11:21:00 -05:00
parent 5bf6d1fa5b
commit 5a642d1cdf
5 changed files with 443 additions and 29 deletions
@@ -0,0 +1,193 @@
using Microsoft.AspNetCore.Antiforgery;
using Microsoft.AspNetCore.Authentication.Cookies;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Routing;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using NSubstitute;
using NSubstitute.ExceptionExtensions;
using ZB.MOM.WW.Auth.Abstractions.Ldap;
using ZB.MOM.WW.Auth.Abstractions.Roles;
using ZB.MOM.WW.ScadaBridge.CentralUI.Auth;
using ZB.MOM.WW.ScadaBridge.Security;
namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Auth;
/// <summary>
/// ScadaBridge#144 — <c>POST /auth/login</c> refuses a successful LDAP bind whose groups map to no
/// ScadaBridge role, and one whose role mapping throws. The refusal must be indistinguishable from a
/// bad password: the same redirect and message, no session cookie, and a login-throttle failure. The
/// reason is logged server-side with the username.
/// </summary>
public class AuthLoginRoleRefusalTests
{
private const string Category = AuthEndpoints.LoggerCategory;
private sealed record Outcome(int Status, string Location, IReadOnlyList<string> SetCookies);
private static RequestDelegate LoginDelegate()
{
var builder = WebApplication.CreateBuilder();
builder.Services.AddRouting();
builder.Services.AddAntiforgery();
builder.Services.AddSingleton<SessionActivityTracker>();
builder.Services.AddSingleton(TimeProvider.System);
using var app = builder.Build();
app.MapAuthEndpoints();
return ((IEndpointRouteBuilder)app).DataSources
.SelectMany(ds => ds.Endpoints)
.OfType<RouteEndpoint>()
.Single(e => e.RoutePattern.RawText == "/auth/login"
&& (e.Metadata.GetMetadata<HttpMethodMetadata>()?.HttpMethods.Contains("POST") ?? false))
.RequestDelegate!;
}
/// <summary>Builds the service rig: LDAP accepts alice/password (groups ["G"]) and rejects alice/wrong.</summary>
private static ServiceProvider Services(
IGroupRoleMapper<string> mapper, LoginThrottle throttle, CapturingLoggerProvider logs)
{
var services = new ServiceCollection();
services.AddLogging(b => b.AddProvider(logs));
services.AddAntiforgery();
services.AddAuthentication(CookieAuthenticationDefaults.AuthenticationScheme).AddCookie();
services.AddSingleton(throttle);
var ldap = Substitute.For<ILdapAuthService>();
ldap.AuthenticateAsync("alice", "password", Arg.Any<CancellationToken>())
.Returns(LdapAuthResult.Success("alice", "Alice", ["Domain Users"]));
ldap.AuthenticateAsync("alice", "wrong", Arg.Any<CancellationToken>())
.Returns(LdapAuthResult.Fail(LdapAuthFailure.BadCredentials));
services.AddSingleton(ldap);
services.AddSingleton(mapper);
return services.BuildServiceProvider();
}
private static async Task<Outcome> PostLogin(ServiceProvider provider, string password)
{
var tokenContext = new DefaultHttpContext { RequestServices = provider };
var tokens = provider.GetRequiredService<IAntiforgery>().GetAndStoreTokens(tokenContext);
var antiforgeryCookie = tokenContext.Response.Headers.SetCookie.Single()!.Split(';')[0];
var context = new DefaultHttpContext { RequestServices = provider };
context.Connection.RemoteIpAddress = System.Net.IPAddress.Loopback;
context.Request.Headers.Cookie = antiforgeryCookie;
context.Request.Method = "POST";
context.Request.ContentType = "application/x-www-form-urlencoded";
var form = $"username=alice&password={password}&{tokens.FormFieldName}={Uri.EscapeDataString(tokens.RequestToken!)}";
context.Request.Body = new MemoryStream(System.Text.Encoding.UTF8.GetBytes(form));
await LoginDelegate()(context);
return new Outcome(
context.Response.StatusCode,
context.Response.Headers.Location.ToString(),
context.Response.Headers.SetCookie.Select(v => v!).ToList());
}
private static IGroupRoleMapper<string> MapperReturning(params string[] roles)
{
var mapper = Substitute.For<IGroupRoleMapper<string>>();
mapper.MapAsync(Arg.Any<IReadOnlyList<string>>(), Arg.Any<CancellationToken>())
.Returns(new GroupRoleMapping<string>(roles, Scope: new RoleMappingResult(roles, [], true)));
return mapper;
}
private static IGroupRoleMapper<string> MapperThrowing()
{
var mapper = Substitute.For<IGroupRoleMapper<string>>();
mapper.MapAsync(Arg.Any<IReadOnlyList<string>>(), Arg.Any<CancellationToken>())
.ThrowsAsync(new InvalidOperationException("configuration database unreachable"));
return mapper;
}
private static LoginThrottle Throttle(int maxFailures = 5) => new(TimeProvider.System, Options.Create(new SecurityOptions
{
MaxLoginFailuresPerWindow = maxFailures,
PerIpMaxFailures = 25,
}));
private static bool HasSessionCookie(Outcome o) =>
o.SetCookies.Any(v => v.StartsWith(".AspNetCore.Cookies=", StringComparison.Ordinal));
/// <summary>The bad-password response every refusal must match exactly.</summary>
private static async Task<Outcome> BadPasswordOutcome()
{
using var provider = Services(MapperReturning(Roles.Viewer), Throttle(), new CapturingLoggerProvider());
return await PostLogin(provider, "wrong");
}
/// <summary>A bind whose groups map to zero roles is refused exactly like a bad password, and logged.</summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Login_ZeroRoles_IsRefusedLikeABadPassword_NoCookie_Logged()
{
var logs = new CapturingLoggerProvider();
using var provider = Services(MapperReturning(), Throttle(), logs);
var outcome = await PostLogin(provider, "password");
var badPassword = await BadPasswordOutcome();
Assert.Equal(StatusCodes.Status302Found, outcome.Status);
Assert.Equal(badPassword.Status, outcome.Status);
Assert.Equal(badPassword.Location, outcome.Location);
Assert.Equal("/login?error=" + Uri.EscapeDataString(LdapAuthFailureMessages.InvalidCredentials), outcome.Location);
Assert.False(HasSessionCookie(outcome));
var entry = Assert.Single(logs.Entries, e => e.Category == Category && e.Level == LogLevel.Warning);
Assert.Contains("alice", entry.Message);
Assert.Contains("maps to a ScadaBridge role", entry.Message);
}
/// <summary>A bind whose role mapping throws is refused exactly like a bad password, and logged with the exception.</summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Login_MapperThrows_IsRefusedLikeABadPassword_NoCookie_Logged()
{
var logs = new CapturingLoggerProvider();
using var provider = Services(MapperThrowing(), Throttle(), logs);
var outcome = await PostLogin(provider, "password");
var badPassword = await BadPasswordOutcome();
Assert.Equal(badPassword.Status, outcome.Status);
Assert.Equal(badPassword.Location, outcome.Location);
Assert.False(HasSessionCookie(outcome));
var entry = Assert.Single(logs.Entries, e => e.Category == Category && e.Level == LogLevel.Warning);
Assert.Contains("alice", entry.Message);
Assert.Contains("role mapping failed", entry.Message);
Assert.IsType<InvalidOperationException>(entry.Exception);
}
/// <summary>
/// A zero-role refusal counts against the login throttle like a bad password, so the throttle
/// cannot be used to tell "right password, no role" apart from "wrong password".
/// </summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Login_ZeroRoles_CountsAsAThrottleFailure()
{
var throttle = Throttle(maxFailures: 2);
using var provider = Services(MapperReturning(), throttle, new CapturingLoggerProvider());
await PostLogin(provider, "password");
await PostLogin(provider, "password");
Assert.True(throttle.IsLockedOut("alice", System.Net.IPAddress.Loopback.ToString()));
}
/// <summary>One mapped role still signs in and sets the session cookie, with no refusal logged.</summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Login_OneRole_SignsIn()
{
var logs = new CapturingLoggerProvider();
using var provider = Services(MapperReturning(Roles.Viewer), Throttle(), logs);
var outcome = await PostLogin(provider, "password");
Assert.Equal(StatusCodes.Status302Found, outcome.Status);
Assert.Equal("/", outcome.Location);
Assert.True(HasSessionCookie(outcome));
Assert.DoesNotContain(logs.Entries, e => e.Category == Category && e.Level >= LogLevel.Warning);
}
}
@@ -1,9 +1,11 @@
using System.Text.Json;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
using Microsoft.Extensions.Options;
using NSubstitute;
using NSubstitute.ExceptionExtensions;
using ZB.MOM.WW.Auth.Abstractions.Ldap;
using ZB.MOM.WW.Auth.Abstractions.Roles;
using ZB.MOM.WW.ScadaBridge.CentralUI.Auth;
@@ -21,22 +23,38 @@ public class AuthTokenEndpointTests
{
private const string Key = "this-is-a-test-signing-key-for-hmac-sha256-must-be-long-enough";
private static HttpContext Context(bool disableLogin, RoleMappingResult mapping, out JwtTokenService jwt)
private static HttpContext Context(bool disableLogin, RoleMappingResult mapping, out JwtTokenService jwt,
string password = "pw", Exception? mapperThrows = null, CapturingLoggerProvider? logs = null,
LoginThrottle? throttle = null)
{
var ldap = Substitute.For<ILdapAuthService>();
ldap.AuthenticateAsync("alice", "pw", Arg.Any<CancellationToken>())
.Returns(LdapAuthResult.Success("alice", "Alice A", ["SiteDeployers"]));
ldap.AuthenticateAsync("alice", "wrong", Arg.Any<CancellationToken>())
.Returns(LdapAuthResult.Fail(LdapAuthFailure.BadCredentials));
var mapper = Substitute.For<IGroupRoleMapper<string>>();
mapper.MapAsync(Arg.Any<IReadOnlyList<string>>(), Arg.Any<CancellationToken>())
.Returns(new GroupRoleMapping<string>(mapping.Roles, Scope: mapping));
if (mapperThrows is not null)
{
mapper.MapAsync(Arg.Any<IReadOnlyList<string>>(), Arg.Any<CancellationToken>()).ThrowsAsync(mapperThrows);
}
else
{
mapper.MapAsync(Arg.Any<IReadOnlyList<string>>(), Arg.Any<CancellationToken>())
.Returns(new GroupRoleMapping<string>(mapping.Roles, Scope: mapping));
}
var options = Options.Create(new SecurityOptions { JwtSigningKey = Key, JwtExpiryMinutes = 15 });
jwt = new JwtTokenService(options, NullLogger<JwtTokenService>.Instance);
var services = new ServiceCollection().AddLogging();
var services = new ServiceCollection().AddLogging(b =>
{
if (logs is not null) b.AddProvider(logs);
});
services.AddSingleton(Options.Create(new AuthDisableLoginOptions { DisableLogin = disableLogin }));
services.AddSingleton<IOptions<SecurityOptions>>(options);
services.AddSingleton(TimeProvider.System);
services.AddSingleton<LoginThrottle>();
if (throttle is not null) services.AddSingleton(throttle);
else services.AddSingleton<LoginThrottle>();
services.AddSingleton(ldap);
services.AddSingleton(mapper);
services.AddSingleton(jwt);
@@ -46,8 +64,9 @@ public class AuthTokenEndpointTests
context.Request.Form = new FormCollection(new()
{
["username"] = "alice",
["password"] = "pw",
["password"] = password,
});
context.Connection.RemoteIpAddress = System.Net.IPAddress.Loopback;
context.Response.Body = new MemoryStream();
return context;
}
@@ -106,4 +125,90 @@ public class AuthTokenEndpointTests
Assert.Equal(404, status);
Assert.False(body.TryGetProperty("access_token", out _));
}
// ---- ScadaBridge#144: no role, no token ----
private static async Task<(int Status, JsonElement Body)> BadPassword()
{
var context = Context(false, new RoleMappingResult([Roles.Deployer], [], true), out _, password: "wrong");
return await Execute(context);
}
private static void AssertSameAsBadPassword((int Status, JsonElement Body) refused, (int Status, JsonElement Body) badPassword)
{
Assert.Equal(401, refused.Status);
Assert.Equal(badPassword.Status, refused.Status);
Assert.Equal(badPassword.Body.GetRawText(), refused.Body.GetRawText());
Assert.Equal(LdapAuthFailureMessages.InvalidCredentials, refused.Body.GetProperty("error").GetString());
Assert.Equal("AUTH_FAILED", refused.Body.GetProperty("code").GetString());
Assert.False(refused.Body.TryGetProperty("access_token", out _));
}
/// <summary>A bind whose groups map to zero roles gets the bad-password 401 and no token; the reason is logged.</summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Token_ZeroRoles_IsRefusedLikeABadPassword_Logged()
{
var logs = new CapturingLoggerProvider();
var context = Context(false, new RoleMappingResult([], [], false), out _, logs: logs);
var refused = await Execute(context);
AssertSameAsBadPassword(refused, await BadPassword());
var entry = Assert.Single(logs.Entries, e => e.Category == AuthEndpoints.LoggerCategory && e.Level == LogLevel.Warning);
Assert.Contains("alice", entry.Message);
Assert.Contains("/auth/token", entry.Message);
Assert.Contains("maps to a ScadaBridge role", entry.Message);
}
/// <summary>A bind whose role mapping throws gets the bad-password 401 and no token; the exception is logged.</summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Token_MapperThrows_IsRefusedLikeABadPassword_Logged()
{
var logs = new CapturingLoggerProvider();
var context = Context(false, new RoleMappingResult([Roles.Deployer], [], true), out _,
mapperThrows: new InvalidOperationException("configuration database unreachable"), logs: logs);
var refused = await Execute(context);
AssertSameAsBadPassword(refused, await BadPassword());
var entry = Assert.Single(logs.Entries, e => e.Category == AuthEndpoints.LoggerCategory && e.Level == LogLevel.Warning);
Assert.Contains("alice", entry.Message);
Assert.Contains("role mapping failed", entry.Message);
Assert.IsType<InvalidOperationException>(entry.Exception);
}
/// <summary>A zero-role refusal counts against the login throttle, like a bad password.</summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Token_ZeroRoles_CountsAsAThrottleFailure()
{
var throttle = new LoginThrottle(TimeProvider.System, Options.Create(new SecurityOptions
{
MaxLoginFailuresPerWindow = 2,
PerIpMaxFailures = 25,
}));
await Execute(Context(false, new RoleMappingResult([], [], false), out _, throttle: throttle));
await Execute(Context(false, new RoleMappingResult([], [], false), out _, throttle: throttle));
Assert.True(throttle.IsLockedOut("alice", System.Net.IPAddress.Loopback.ToString()));
}
/// <summary>Exactly one mapped role still gets a token carrying that role.</summary>
/// <returns>A task that represents the asynchronous operation.</returns>
[Fact]
public async Task Token_OneRole_IsIssued()
{
var logs = new CapturingLoggerProvider();
var context = Context(false, new RoleMappingResult([Roles.Viewer], [], true), out var jwt, logs: logs);
var (status, body) = await Execute(context);
Assert.Equal(200, status);
var principal = jwt.ValidateToken(body.GetProperty("access_token").GetString()!);
Assert.Equal([Roles.Viewer], principal!.FindAll(JwtTokenService.RoleClaimType).Select(c => c.Value));
Assert.DoesNotContain(logs.Entries, e => e.Category == AuthEndpoints.LoggerCategory && e.Level >= LogLevel.Warning);
}
}
@@ -0,0 +1,37 @@
using System.Collections.Concurrent;
using Microsoft.Extensions.Logging;
namespace ZB.MOM.WW.ScadaBridge.CentralUI.Tests.Auth;
/// <summary>An in-memory logger provider that records every formatted log line with its category and level.</summary>
internal sealed class CapturingLoggerProvider : ILoggerProvider
{
/// <summary>One captured log entry.</summary>
/// <param name="Category">The logger category.</param>
/// <param name="Level">The log level.</param>
/// <param name="Message">The formatted message.</param>
/// <param name="Exception">The logged exception, if any.</param>
public sealed record Entry(string Category, LogLevel Level, string Message, Exception? Exception);
/// <summary>Every entry logged through this provider, in order.</summary>
public ConcurrentQueue<Entry> Entries { get; } = new();
/// <inheritdoc />
public ILogger CreateLogger(string categoryName) => new Logger(categoryName, Entries);
/// <inheritdoc />
public void Dispose()
{
}
private sealed class Logger(string category, ConcurrentQueue<Entry> sink) : ILogger
{
public IDisposable? BeginScope<TState>(TState state) where TState : notnull => null;
public bool IsEnabled(LogLevel logLevel) => true;
public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception? exception,
Func<TState, Exception?, string> formatter) =>
sink.Enqueue(new Entry(category, logLevel, formatter(state, exception), exception));
}
}
@@ -12,6 +12,10 @@ public class RoutePolicyCoverageTests
[Fact]
public void EveryRoutableComponent_HasItsReviewedPolicy_IncludingExternalSecrets()
{
// "authenticated" (bare [Authorize]) is safe only because sign-in requires a mapped role:
// /auth/login and /auth/token refuse a zero-role bind, and a session whose roles drop to zero
// is ended by CookieSessionValidator (ScadaBridge#144, "no role, no login"). Do not add an
// "authenticated" page that would be unsafe for a holder of any single role.
var expected = new Dictionary<string, string>
{
["/"] = "authenticated",