perf: close Theme 6 — 11 allocation / N+1 / lock-contention findings

Well-localised perf fixes across 8 modules. Lock decoupling / SQL streaming: - AuditLog-005: SqliteAuditWriter gains dedicated read-only _readConnection (+ _readLock) backed by WAL journal mode. GetBacklogStatsAsync, ReadPendingAsync, ReadPendingSinceAsync, ReadForwardedAsync no longer contend with the hot-path INSERT lock — backlog probes on a 30s timer can't stall the writer under multi-hundred-K Pending backlog. - SEL-022: dropped Cache=Shared from SiteEventLogger's default connection string (single-connection logger; mode was dormant config). Memory / streaming: - CLI-019: bundle export streams base64 in 1 MB-aligned chunks via Convert.TryFromBase64Chars straight into the FileStream — no more full-bundle byte[] allocation. - CentralUI-031: TransportImport now stages the upload to a per-session temp file under Path.GetTempPath() (replaces in-memory byte[] field); page implements IDisposable to delete the temp file on reset / new upload / dispose. Per-circuit working set drops from ~100 MB to ~80 KB. N+1 hoisting: - Transport-008: added ITemplateEngineRepository.GetTemplatesWithChildrenAsync bulk method; BundleImporter.PreviewAsync calls it once instead of per- template-name. Single query with .Include(...).AsSplitQuery(). - DM-023: BuildDeployArtifactsCommandAsync's per-site loop now references a pre-fetched GlobalArtifactSnapshot (shared scripts, external systems, DB connections, notification lists, SMTP) instead of re-querying per site. - MgmtSvc-023: HandleQueryDeployments unfiltered branch uses one GetAllInstancesAsync bulk load + Dictionary<int,int?> lookup (was a GetInstanceByIdAsync per record). Small allocations / per-tick rebuilds: - InboundAPI-019: AuditWriteMiddleware gates EnableBuffering() on RequestHasBody() so GET/HEAD/DELETE/TRACE/OPTIONS and Content-Length:0 requests skip the FileBufferingReadStream allocation. - NotifOutbox-006: ResolveAdapters dictionary now cached on _adaptersCache (built lazily on first sweep) + actor-lifetime _adaptersScope; ResolveAdapters no longer rebuilds per dispatch tick. Verify-only: - Comm-017: Confirmed _inProgressDeployments was deleted by Comm-016 in commit ac96b83 — marked Resolved with that attribution. No code change. Doc-correction: - NS-022: Updated MailKitSmtpClientWrapper XML doc to spell out single- connection / per-delivery-factory contract (option (b) — transient client per Send — rejected because it re-handshakes TLS per email). 10+ new regression tests across 8 test projects. Build clean; affected suites all green. README regenerated: 54 open (was 65).
2026-05-28 07:47:24 -04:00
parent 2ed5c6c379
commit 55f46e7c92
34 changed files with 1131 additions and 149 deletions
@@ -395,6 +395,63 @@ public class NotificationOutboxActorDispatchTests : TestKit
            "PostStop did not cancel the in-flight delivery promptly.");
    }

+    // ── NotificationOutbox-006: adapter dictionary cached for the actor's lifetime ──
+
+    [Fact]
+    public void Dispatch_ResolvesAdaptersOnce_AcrossMultipleSweeps()
+    {
+        // NotificationOutbox-006: adapter registration is static per process lifetime,
+        // so the NotificationType -> adapter lookup must be built ONCE for the actor's
+        // lifetime, not per dispatch sweep. The cache is paired with an actor-lifetime
+        // DI scope (see _adaptersScope) so scoped adapter instances are reused safely.
+        SetupSmtpRetryPolicy(maxRetries: 5, retryDelay: TimeSpan.FromMinutes(1));
+        // Isolated substitutes for this test — we replace the dispatcher's per-sweep
+        // INotificationOutboxRepository registration with a private counting factory,
+        // so we don't mutate the shared _outboxRepository field that other tests in
+        // this class configure differently.
+        var outboxRepository = Substitute.For<INotificationOutboxRepository>();
+        outboxRepository.GetDueAsync(Arg.Any<DateTimeOffset>(), Arg.Any<int>(), Arg.Any<CancellationToken>())
+            .Returns(_ => new[] { MakeNotification() });
+
+        // Counting factory: increments each time the DI container resolves an
+        // INotificationDeliveryAdapter. Pre-fix this would have ticked once per
+        // sweep; post-fix it ticks exactly once for the actor's lifetime.
+        var resolutionCount = 0;
+        var services = new ServiceCollection();
+        services.AddScoped(_ => outboxRepository);
+        services.AddScoped(_ => _notificationRepository);
+        services.AddScoped<INotificationDeliveryAdapter>(_ =>
+        {
+            Interlocked.Increment(ref resolutionCount);
+            return new StubAdapter(() => DeliveryOutcome.Success("ops@example.com"));
+        });
+        var sp = services.BuildServiceProvider();
+
+        var actor = Sys.ActorOf(Props.Create(() => new NotificationOutboxActor(
+            sp,
+            new NotificationOutboxOptions { DispatchInterval = TimeSpan.FromHours(1) },
+            new NoOpCentralAuditWriter(),
+            NullLogger<NotificationOutboxActor>.Instance)));
+
+        // Fire three sweeps end-to-end. Each waits on the previous via the
+        // in-flight guard, so the UpdateAsync count climbs monotonically.
+        actor.Tell(InternalMessages.DispatchTick.Instance);
+        AwaitAssert(() => outboxRepository.Received(1).UpdateAsync(
+            Arg.Any<Notification>(), Arg.Any<CancellationToken>()));
+
+        actor.Tell(InternalMessages.DispatchTick.Instance);
+        AwaitAssert(() => outboxRepository.Received(2).UpdateAsync(
+            Arg.Any<Notification>(), Arg.Any<CancellationToken>()));
+
+        actor.Tell(InternalMessages.DispatchTick.Instance);
+        AwaitAssert(() => outboxRepository.Received(3).UpdateAsync(
+            Arg.Any<Notification>(), Arg.Any<CancellationToken>()));
+
+        // The adapter resolution must have happened EXACTLY ONCE despite three
+        // dispatch sweeps. Pre-fix this would have been 3 (or more).
+        Assert.Equal(1, resolutionCount);
+    }
+
    [Fact]
    public void OverlappingTicks_WhileDispatchInFlight_DoNotClaimConcurrently()
    {