dohertj2/ScadaBridge
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(sms): reject notification-list Type change on update (S6 review follow-up)

Browse Source
This commit is contained in:
Joseph Doherty
2026-06-19 10:51:58 -04:00
parent 58ac06a358
commit 538117d114
2 changed files with 65 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.ManagementService.Tests/ManagementActorTests.cs
+63 -1
View File
@@ -1429,11 +1429,13 @@ public class ManagementActorTests : TestKit, IDisposable
[Fact]
public void UpdateNotificationList_WithSmsType_PersistsSms()
{
// Updating an existing SMS list (same type) must succeed and preserve the
// SMS channel — the immutability guard only fires when Type changes.
var notifRepo = Substitute.For<INotificationRepository>();
var existing = new Commons.Entities.Notifications.NotificationList("Ops")
{
Id = 7,
Type = Commons.Types.Enums.NotificationType.Email,
Type = Commons.Types.Enums.NotificationType.Sms,
};
notifRepo.GetNotificationListByIdAsync(7, Arg.Any<CancellationToken>()).Returns(existing);
notifRepo.GetRecipientsByListIdAsync(7, Arg.Any<CancellationToken>())
@@ -1453,6 +1455,66 @@ public class ManagementActorTests : TestKit, IDisposable
Assert.Equal(Commons.Types.Enums.NotificationType.Sms, existing.Type);
}
[Fact]
public void UpdateNotificationList_ChangingType_IsRejected()
{
// Attempting to change an Email list's Type to Sms must return a
// COMMAND_FAILED error — the Type field is immutable after creation.
var notifRepo = Substitute.For<INotificationRepository>();
var existing = new Commons.Entities.Notifications.NotificationList("Ops")
{
Id = 8,
Type = Commons.Types.Enums.NotificationType.Email,
};
notifRepo.GetNotificationListByIdAsync(8, Arg.Any<CancellationToken>()).Returns(existing);
notifRepo.GetRecipientsByListIdAsync(8, Arg.Any<CancellationToken>())
.Returns(new List<Commons.Entities.Notifications.NotificationRecipient>());
_services.AddScoped(_ => notifRepo);
var actor = CreateActor();
var envelope = Envelope(
new UpdateNotificationListCommand(8, "Ops", new[] { "+15551230000" },
Commons.Types.Enums.NotificationType.Sms),
"Designer");
actor.Tell(envelope);
var response = ExpectMsg<ManagementError>(TimeSpan.FromSeconds(5));
Assert.Equal(envelope.CorrelationId, response.CorrelationId);
Assert.Equal("COMMAND_FAILED", response.ErrorCode);
Assert.Contains("Type cannot be changed", response.Error);
}
[Fact]
public void UpdateNotificationList_SameEmailType_Succeeds()
{
// Updating an Email list while keeping Type = Email must succeed — the
// immutability guard must not fire on same-type updates.
var notifRepo = Substitute.For<INotificationRepository>();
var existing = new Commons.Entities.Notifications.NotificationList("Alerts")
{
Id = 9,
Type = Commons.Types.Enums.NotificationType.Email,
};
notifRepo.GetNotificationListByIdAsync(9, Arg.Any<CancellationToken>()).Returns(existing);
notifRepo.GetRecipientsByListIdAsync(9, Arg.Any<CancellationToken>())
.Returns(new List<Commons.Entities.Notifications.NotificationRecipient>());
_services.AddScoped(_ => notifRepo);
var actor = CreateActor();
var envelope = Envelope(
new UpdateNotificationListCommand(9, "Alerts-Renamed", new[] { "ops@example.com" },
Commons.Types.Enums.NotificationType.Email),
"Designer");
actor.Tell(envelope);
var response = ExpectMsg<ManagementSuccess>(TimeSpan.FromSeconds(5));
Assert.Equal(envelope.CorrelationId, response.CorrelationId);
Assert.Equal("Alerts-Renamed", existing.Name);
Assert.Equal(Commons.Types.Enums.NotificationType.Email, existing.Type);
}
[Fact]
public void UpdateSmsConfig_WithApiBaseUrlAndAuthToken_PersistsThem()
{