docs(tests): fix CommentChecker findings across tests/ — 13,392 → 0 (repo-wide scan clean)

Comment/XML-doc changes only:
- add summaries to ~10k test methods, fixtures, fakes and helpers
  (+ <param> on theories, <returns> on async Task methods,
  <inheritdoc/> on interface implementations the checker can resolve)
- strip ~2.6k project-tracking references (WP*, P*-*, row-NN, Task N,
  #NN, Component-0NN) from comments, keeping the explanatory text;
  reword false positives in comments only
- real docs on fakes implementing BCL/library interfaces
  (IDisposable, ILogger, IOptionsMonitor, IAsyncLifetime)
- reword the last 5 src/ false positives (CWE-1236, failures-1,
  year-0001, M365)

Only non-comment edits: four one-line nested classes split across lines
so members can carry docs. Build 0 errors / 0 warnings.
This commit is contained in:
Joseph Doherty
2026-10-07 15:05:49 -04:00
parent 0ffd4bdbea
commit 513fa1aa16
998 changed files with 17896 additions and 2395 deletions
@@ -51,10 +51,11 @@ public class StandbyHealthCheckLogNoiseTests
.ForContext("SourceContext", category)
.Write(level, Template, checkName, status, 1.0, "some message");
/// <summary>Verifies that the standby active-node verdict is not logged.</summary>
[Fact]
public void StandbyActiveNodeVerdict_IsNotLogged()
{
// The row-71 regression: "Health check active-node with status Unhealthy … 'not the
// The regression: "Health check active-node with status Unhealthy … 'not the
// site pair primary (standby)'" at Error, once per probe, forever.
var sink = new InMemorySink();
var logger = BuildLogger(sink);
@@ -65,6 +66,8 @@ public class StandbyHealthCheckLogNoiseTests
Assert.Empty(sink.LogEvents);
}
/// <summary>Verifies that a genuine failure of a health check still logs at Error.</summary>
/// <param name="checkName">The name of the failing health check.</param>
[Theory]
[InlineData("localdb")]
[InlineData("akka-cluster")]
@@ -85,6 +88,7 @@ public class StandbyHealthCheckLogNoiseTests
Assert.Equal(LogEventLevel.Error, evt.Level);
}
/// <summary>Verifies that a healthy active-node verdict is unaffected.</summary>
[Fact]
public void ActiveNodeHealthyVerdict_IsUnaffected()
{
@@ -99,6 +103,7 @@ public class StandbyHealthCheckLogNoiseTests
Assert.Single(sink.LogEvents);
}
/// <summary>Verifies that a degraded active-node verdict is unaffected.</summary>
[Fact]
public void ActiveNodeDegradedVerdict_IsUnaffected()
{
@@ -113,6 +118,7 @@ public class StandbyHealthCheckLogNoiseTests
Assert.Single(sink.LogEvents);
}
/// <summary>Verifies that an error mentioning the active node from another category is not suppressed.</summary>
[Fact]
public void AnErrorMentioningActiveNode_FromAnotherCategory_IsNotSuppressed()
{
@@ -131,6 +137,7 @@ public class StandbyHealthCheckLogNoiseTests
Assert.Single(sink.LogEvents);
}
/// <summary>Verifies that ordinary errors with no health-check properties are not suppressed.</summary>
[Fact]
public void OrdinaryErrorsWithNoHealthCheckProperties_AreNotSuppressed()
{
@@ -142,6 +149,7 @@ public class StandbyHealthCheckLogNoiseTests
Assert.Single(sink.LogEvents);
}
/// <summary>Verifies that the predicate rejects a null event.</summary>
[Fact]
public void Predicate_RejectsANullEvent()
{