docs(tests): fix CommentChecker findings across tests/ — 13,392 → 0 (repo-wide scan clean)
Comment/XML-doc changes only: - add summaries to ~10k test methods, fixtures, fakes and helpers (+ <param> on theories, <returns> on async Task methods, <inheritdoc/> on interface implementations the checker can resolve) - strip ~2.6k project-tracking references (WP*, P*-*, row-NN, Task N, #NN, Component-0NN) from comments, keeping the explanatory text; reword false positives in comments only - real docs on fakes implementing BCL/library interfaces (IDisposable, ILogger, IOptionsMonitor, IAsyncLifetime) - reword the last 5 src/ false positives (CWE-1236, failures-1, year-0001, M365) Only non-comment edits: four one-line nested classes split across lines so members can carry docs. Build 0 errors / 0 warnings.
This commit is contained in:
+9
-2
@@ -13,7 +13,7 @@ using ZB.MOM.WW.ScadaBridge.Commons.Types.Templates;
|
||||
namespace ZB.MOM.WW.ScadaBridge.DeploymentManager.Tests;
|
||||
|
||||
/// <summary>
|
||||
/// M2.8 (#23): proves the deploy path (FlatteningPipeline.FlattenAndValidateAsync)
|
||||
/// Proves the deploy path (FlatteningPipeline.FlattenAndValidateAsync)
|
||||
/// opts into connection-binding enforcement, so a data-sourced attribute with no
|
||||
/// binding gates the deployment as an ERROR (not just a warning), and that a binding
|
||||
/// resolving to a connection that actually exists at the target site passes.
|
||||
@@ -30,6 +30,7 @@ public class FlatteningPipelineConnectionBindingTests
|
||||
private readonly ISharedSchemaRepository _sharedSchemaRepo = Substitute.For<ISharedSchemaRepository>();
|
||||
private readonly FlatteningPipeline _sut;
|
||||
|
||||
/// <summary>Initializes a new instance of the <c>FlatteningPipelineConnectionBindingTests</c> class.</summary>
|
||||
public FlatteningPipelineConnectionBindingTests()
|
||||
{
|
||||
_sharedSchemaRepo.ListAsync(Arg.Any<CancellationToken>())
|
||||
@@ -79,6 +80,8 @@ public class FlatteningPipelineConnectionBindingTests
|
||||
.Returns([connection]);
|
||||
}
|
||||
|
||||
/// <summary>Verifies that flatten and validate, when data sourced attribute with no binding, reports binding error.</summary>
|
||||
/// <returns>A task that represents the asynchronous operation.</returns>
|
||||
[Fact]
|
||||
public async Task FlattenAndValidate_DataSourcedAttributeWithNoBinding_ReportsBindingError()
|
||||
{
|
||||
@@ -92,6 +95,8 @@ public class FlatteningPipelineConnectionBindingTests
|
||||
e => e.Category == ValidationCategory.ConnectionBinding);
|
||||
}
|
||||
|
||||
/// <summary>Verifies that flatten and validate, when binding to existing site connection, no binding error.</summary>
|
||||
/// <returns>A task that represents the asynchronous operation.</returns>
|
||||
[Fact]
|
||||
public async Task FlattenAndValidate_BindingToExistingSiteConnection_NoBindingError()
|
||||
{
|
||||
@@ -104,10 +109,12 @@ public class FlatteningPipelineConnectionBindingTests
|
||||
e => e.Category == ValidationCategory.ConnectionBinding);
|
||||
}
|
||||
|
||||
/// <summary>Verifies that flatten and validate, when binding to stale deleted connection, reports binding error.</summary>
|
||||
/// <returns>A task that represents the asynchronous operation.</returns>
|
||||
[Fact]
|
||||
public async Task FlattenAndValidate_BindingToStaleDeletedConnection_ReportsBindingError()
|
||||
{
|
||||
// M2.8 (#23): FlatteningService.ApplyConnectionBindings silently drops a
|
||||
// FlatteningService.ApplyConnectionBindings silently drops a
|
||||
// binding whose DataConnectionId doesn't resolve to any loaded site
|
||||
// DataConnection (stale / deleted connection). The flattener leaves
|
||||
// BoundDataConnectionId == null, so the validator treats the attribute as
|
||||
|
||||
Reference in New Issue
Block a user