dohertj2/ScadaBridge
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

test(playwright): DeploymentActionTests load the lazy Topology tree via a shared helper

Browse Source 
The Topology page has loaded lazily (bounded instance pages behind 'Load
instances' loaders) since 9ee402bb (2026-09-09); TopologyAreaTests was
updated then but DeploymentActionTests still relied on one Expand-all click
revealing instance rows, so all four facts timed out locating the row. Move
OpenStableTopologyAsync into TopologyPageHelper and use it from both.
This commit is contained in:
Joseph Doherty
2026-10-22 13:48:52 -04:00
parent 560adefb0c
commit 4ae3ed3fdd
3 changed files with 59 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ZB.MOM.WW.ScadaBridge.CentralUI.PlaywrightTests/Deployment/TopologyAreaTests.cs
+2 -34
View File
@@ -302,38 +302,6 @@ public class TopologyAreaTests : IClassFixture<DeploymentFixture>
}
}
/// <summary>
/// Navigates to the Topology page and returns a page whose tree is stable and
/// fully expanded: it unchecks the <c>#live-updates</c> switch (stopping the 15s
/// timer that would otherwise reload the tree and collapse expansions / tear down
/// open dialogs and rename inputs), then clicks <c>Expand all areas</c> so nested
/// area nodes are rendered and locatable.
/// </summary>
private static async Task<IPage> OpenStableTopologyAsync(PlaywrightFixture pw)
{
var page = await pw.NewAuthenticatedPageAsync();
await page.GotoAsync($"{PlaywrightFixture.BaseUrl}/deployment/topology");
await page.WaitForLoadStateAsync(LoadState.NetworkIdle);
var live = page.Locator("#live-updates");
if (await live.IsCheckedAsync()) await live.UncheckAsync(); // stop the 15s tree reload
// Lazy topology loads a bounded first page per branch. These small authoring
// fixtures need their sites/areas loaded before addressing labels or instances.
// "Expand all" re-renders over the SignalR circuit, so the click returns before the
// newly-expanded branches (and their "Load instances" loaders) exist. Wait until no
// collapsed branch remains before counting loaders — counting immediately raced the
// render and returned an unexpanded tree whenever the round-trip lost.
var collapsed = page.Locator("li[role='treeitem'][aria-expanded='false']");
for (var branch = 0; branch < 300; branch++)
{
await page.Locator("button[aria-label='Expand all areas']").ClickAsync();
await Assertions.Expect(collapsed).ToHaveCountAsync(0);
var load = page.GetByRole(AriaRole.Button, new() { Name = "Load instances", Exact = true });
if (await load.CountAsync() == 0) return page;
var pages = page.GetByText("Page 1", new() { Exact = true });
var count = await pages.CountAsync();
await load.First.ClickAsync();
await Assertions.Expect(pages).ToHaveCountAsync(count + 1);
}
throw new InvalidOperationException("Topology fixture exceeded 300 branches.");
}
private static Task<IPage> OpenStableTopologyAsync(PlaywrightFixture pw) =>
TopologyPageHelper.OpenStableTopologyAsync(pw);
}