docs+code: close Theme 1 — 24 design-doc / XML-doc drift findings

Doc/XML-comment drift + small adherence fixes across 17 modules. Highlights: - Host-017: site CoordinatedShutdown ordering — SiteStreamGrpcServer gains CancelAllStreams() (refuse new streams, cancel active), wired into Program.cs site branch via ApplicationStopping. - InboundAPI-021: ParentExecutionId now travels on RouteToGet/SetAttributes symmetric with RouteToCallRequest; RouteHelper stamps from _parentExecutionId. - ClusterInfra-012: ClusterOptionsValidator now requires both seed nodes. - Comm-018: SiteCommunicationActor.HeartbeatMessage.IsActive derived from cluster leader check (was hardcoded true). - DM-020: reconciliation audit row attributes the current user, not prior deployer. - SEL-019: EventLogPurgeService early-exits on standby via active-node check. - Plus comment/XML-doc accuracy fixes across AuditLog, ConfigurationDatabase, NotificationOutbox, SiteRuntime, SiteCallAudit; doc refreshes for Component- Commons / -ManagementService / -CLI / -ExternalSystemGateway / -HealthMonitoring / -Transport / -ConfigurationDatabase; CD-023 index-name doc alignment. 11 new regression tests (RouteHelper x4, SiteStreamGrpcServer x2, ClusterOptionsValidator x1, SiteCommunicationActor x1, DeploymentService x1, EventLogPurgeService x3). Build clean (0 warnings); InboundAPI/Communication/ Host suites all green. README regenerated: 112 open (was 136).
2026-05-28 06:28:31 -04:00
parent e3ca9af1be
commit 487859bff0
51 changed files with 940 additions and 188 deletions
@@ -330,4 +330,75 @@ public class RouteHelperTests

        Assert.Equal(deadline.Token, seen);
    }
+
+    // --- InboundAPI-021: ParentExecutionId flows through Get/SetAttributes too ---
+
+    [Fact]
+    public async Task GetAttributes_WithoutParentExecutionId_LeavesParentExecutionIdNull()
+    {
+        SiteResolves("inst-1", "SiteA");
+        RouteToGetAttributesRequest? captured = null;
+        _router.RouteToGetAttributesAsync("SiteA", Arg.Do<RouteToGetAttributesRequest>(r => captured = r), Arg.Any<CancellationToken>())
+            .Returns(ci => new RouteToGetAttributesResponse(
+                ((RouteToGetAttributesRequest)ci[1]).CorrelationId,
+                new Dictionary<string, object?>(), true, null, DateTimeOffset.UtcNow));
+
+        await CreateHelper().To("inst-1").GetAttributes(new[] { "a" });
+
+        Assert.NotNull(captured);
+        Assert.Null(captured!.ParentExecutionId);
+    }
+
+    [Fact]
+    public async Task GetAttributes_WithParentExecutionId_CarriesItOnRouteToGetAttributesRequest()
+    {
+        // Symmetric with Call: a RouteHelper bound to the inbound request's
+        // ExecutionId stamps it onto the routed GetAttributes request so
+        // future site-side audit can record the inbound→site link.
+        SiteResolves("inst-1", "SiteA");
+        var inboundExecutionId = Guid.NewGuid();
+        RouteToGetAttributesRequest? captured = null;
+        _router.RouteToGetAttributesAsync("SiteA", Arg.Do<RouteToGetAttributesRequest>(r => captured = r), Arg.Any<CancellationToken>())
+            .Returns(ci => new RouteToGetAttributesResponse(
+                ((RouteToGetAttributesRequest)ci[1]).CorrelationId,
+                new Dictionary<string, object?>(), true, null, DateTimeOffset.UtcNow));
+
+        var bound = CreateHelper().WithParentExecutionId(inboundExecutionId);
+        await bound.To("inst-1").GetAttributes(new[] { "a" });
+
+        Assert.NotNull(captured);
+        Assert.Equal(inboundExecutionId, captured!.ParentExecutionId);
+    }
+
+    [Fact]
+    public async Task SetAttributes_WithoutParentExecutionId_LeavesParentExecutionIdNull()
+    {
+        SiteResolves("inst-1", "SiteA");
+        RouteToSetAttributesRequest? captured = null;
+        _router.RouteToSetAttributesAsync("SiteA", Arg.Do<RouteToSetAttributesRequest>(r => captured = r), Arg.Any<CancellationToken>())
+            .Returns(ci => new RouteToSetAttributesResponse(
+                ((RouteToSetAttributesRequest)ci[1]).CorrelationId, true, null, DateTimeOffset.UtcNow));
+
+        await CreateHelper().To("inst-1").SetAttributes(new Dictionary<string, string> { ["x"] = "1" });
+
+        Assert.NotNull(captured);
+        Assert.Null(captured!.ParentExecutionId);
+    }
+
+    [Fact]
+    public async Task SetAttributes_WithParentExecutionId_CarriesItOnRouteToSetAttributesRequest()
+    {
+        SiteResolves("inst-1", "SiteA");
+        var inboundExecutionId = Guid.NewGuid();
+        RouteToSetAttributesRequest? captured = null;
+        _router.RouteToSetAttributesAsync("SiteA", Arg.Do<RouteToSetAttributesRequest>(r => captured = r), Arg.Any<CancellationToken>())
+            .Returns(ci => new RouteToSetAttributesResponse(
+                ((RouteToSetAttributesRequest)ci[1]).CorrelationId, true, null, DateTimeOffset.UtcNow));
+
+        var bound = CreateHelper().WithParentExecutionId(inboundExecutionId);
+        await bound.To("inst-1").SetAttributes(new Dictionary<string, string> { ["x"] = "1" });
+
+        Assert.NotNull(captured);
+        Assert.Equal(inboundExecutionId, captured!.ParentExecutionId);
+    }
 }