fix(communication): failback probe sentinel uses an illegal actor name so it can never match a real instance (review 2026-10-21 03/P-2 follow-up)

2026-10-22 08:30:38 -04:00
parent 82976b7377
commit 429ccb8d90
2 changed files with 16 additions and 2 deletions
@@ -150,6 +150,14 @@ public class SitePairChannelProviderFailbackTests
        Assert.Contains(SitePairChannelProvider.ReadinessProbeInstance, handler.LastRequestBody);
    }

+    /// <summary>Verifies that the probe's sentinel instance name can never be a real instance (it is not a legal actor name).</summary>
+    [Fact]
+    public void ReadinessProbeSentinel_IsNotALegalInstanceName()
+    {
+        Assert.False(ZB.MOM.WW.ScadaBridge.Commons.Validation.ActorNameRules.IsValid(
+            SitePairChannelProvider.ReadinessProbeInstance));
+    }
+
    /// <summary>
    /// Minimal in-memory gRPC server stand-in: a trailers-only Unavailable (+ the not-dispatched
    /// trailer) while not ready, or a framed <see cref="LifecycleReply"/> with OK status when ready.